[Buildroot] [PATCH v2 1/1] automake: fix unescaped left brace warning patch.

[Buildroot] [PATCH v2 1/1] automake: fix unescaped left brace warning patch.

[Adam Duskett]

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
 .../0002-port-to-perl-5.22-and-later.patch         | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/automake/0002-port-to-perl-5.22-and-later.patch

diff --git a/package/automake/0002-port-to-perl-5.22-and-later.patch b/package/automake/0002-port-to-perl-5.22-and-later.patch
new file mode 100644
index 0000000..a7213d4
--- /dev/null
+++ b/package/automake/0002-port-to-perl-5.22-and-later.patch
@@ -0,0 +1,23 @@
+Without this change, Perl 5.22 complains "Unescaped left brace in
+regex is deprecated" and this is planned to become a hard error in
+Perl 5.26.  See:
+http://search.cpan.org/dist/perl-5.22.0/pod/perldelta.pod#A_literal_%22{%22_should_now_be_escaped_in_a_pattern
+* bin/automake.in (substitute_ac_subst_variables): Escape left brace.
+
+Backported from:
+http://git.savannah.gnu.org/cgit/automake.git/commit/?id=13f00eb4493c217269b76614759e452d8302955e
+Original author: Paul Eggert <eggert@cs.ucla.edu>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+
+diff --git a/bin/automake.in b/bin/automake.in
+index a3a0aa3..2c8f31e 100644
+--- a/bin/automake.in
++++ b/bin/automake.in
+@@ -3878,7 +3878,7 @@ sub substitute_ac_subst_variables_worker
+ sub substitute_ac_subst_variables
+ {
+   my ($text) = @_;
+-  $text =~ s/\${([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge;
++  $text =~ s/\$[{]([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge;
+   return $text;
+ }
-- 
2.9.3

[Buildroot] [PATCH v2 1/1] automake: fix unescaped left brace warning patch.

[Adam Duskett]

Automake currently has a unescaped left brace in it's automake.in folder
that generates the warning:
"Unescaped left brace in regex is deprecated, passed through in regex;"
This patch, which is backported from upstream fixes this warning.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v1 - v2:
  - Added backport information.
  
 .../0002-port-to-perl-5.22-and-later.patch         | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/automake/0002-port-to-perl-5.22-and-later.patch

diff --git a/package/automake/0002-port-to-perl-5.22-and-later.patch b/package/automake/0002-port-to-perl-5.22-and-later.patch
new file mode 100644
index 0000000..a7213d4
--- /dev/null
+++ b/package/automake/0002-port-to-perl-5.22-and-later.patch
@@ -0,0 +1,23 @@
+Without this change, Perl 5.22 complains "Unescaped left brace in
+regex is deprecated" and this is planned to become a hard error in
+Perl 5.26.  See:
+http://search.cpan.org/dist/perl-5.22.0/pod/perldelta.pod#A_literal_%22{%22_should_now_be_escaped_in_a_pattern
+* bin/automake.in (substitute_ac_subst_variables): Escape left brace.
+
+Backported from:
+http://git.savannah.gnu.org/cgit/automake.git/commit/?id=13f00eb4493c217269b76614759e452d8302955e
+Original author: Paul Eggert <eggert@cs.ucla.edu>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+
+diff --git a/bin/automake.in b/bin/automake.in
+index a3a0aa3..2c8f31e 100644
+--- a/bin/automake.in
++++ b/bin/automake.in
+@@ -3878,7 +3878,7 @@ sub substitute_ac_subst_variables_worker
+ sub substitute_ac_subst_variables
+ {
+   my ($text) = @_;
+-  $text =~ s/\${([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge;
++  $text =~ s/\$[{]([^ \t=:+{}]+)}/substitute_ac_subst_variables_worker ($1)/ge;
+   return $text;
+ }
-- 
2.9.3

[Buildroot] [PATCH v2 1/1] automake: fix unescaped left brace warning patch.

[Thomas Petazzoni]

Hello,

On Mon,  6 Mar 2017 08:23:59 -0500, Adam Duskett wrote:
> Automake currently has a unescaped left brace in it's automake.in folder
> that generates the warning:
> "Unescaped left brace in regex is deprecated, passed through in regex;"
> This patch, which is backported from upstream fixes this warning.
> 
> Signed-off-by: Adam Duskett <aduskett@codeblue.com>

I've applied. However, you should format the patches of projects
managed with Git using "git format-patch". So the automake patch should
have been Git formatted. I've fixed that before applying.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v2 1/1] automake: fix unescaped left brace warning patch.

[Jörg Krause]

Hello,

On Mon, 2017-03-20 at 21:45 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon,  6 Mar 2017 08:23:59 -0500, Adam Duskett wrote:
> > Automake currently has a unescaped left brace in it's automake.in
> > folder
> > that generates the warning:
> > "Unescaped left brace in regex is deprecated, passed through in
> > regex;"
> > This patch, which is backported from upstream fixes this warning.
> > 
> > Signed-off-by: Adam Duskett <aduskett@codeblue.com>
> 
> I've applied. However, you should format the patches of projects
> managed with Git using "git format-patch". So the automake patch
> should
> have been Git formatted. I've fixed that before applying.

We should apply the patch to the 2017.02.x branch, too. Perl 5.26 is
treating the warning as an error. This patch fixes building alsa-lib
for me on the 2017.02.x branch.

J?rg

[Buildroot] [PATCH v2 1/1] automake: fix unescaped left brace warning patch.

[Peter Korsgaard]

>>>>> "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:

Hi,

 >> I've applied. However, you should format the patches of projects
 >> managed with Git using "git format-patch". So the automake patch
 >> should
 >> have been Git formatted. I've fixed that before applying.

 > We should apply the patch to the 2017.02.x branch, too. Perl 5.26 is
 > treating the warning as an error. This patch fixes building alsa-lib
 > for me on the 2017.02.x branch.

Ok - Committed to 2017.02.x, thanks!

-- 
Bye, Peter Korsgaard