Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/python: add optional support for libintl
@ 2017-03-12 14:06 Bernd Kuhls
  2017-03-12 15:07 ` Thomas Petazzoni
  2017-03-13 23:25 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2017-03-12 14:06 UTC (permalink / raw)
  To: buildroot

Python links to gettext when available:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/python2.7/lib-dynload/_locale.so | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libintl.so.8]
 0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]

In comparison the same library compiled without gettext:

$ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/python2.7/lib-dynload/_locale.so | grep NEEDED
 0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
 0x00000001 (NEEDED)                     Shared library: [libc.so.0]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/python/python.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/python/python.mk b/package/python/python.mk
index 7541e0bc4..8f4e298c4 100644
--- a/package/python/python.mk
+++ b/package/python/python.mk
@@ -60,6 +60,10 @@ HOST_PYTHON_DEPENDENCIES = host-expat host-zlib
 
 PYTHON_INSTALL_STAGING = YES
 
+ifeq ($(BR2_PACKAGE_GETTEXT),y)
+PYTHON_DEPENDENCIES += gettext
+endif
+
 ifeq ($(BR2_PACKAGE_PYTHON_READLINE),y)
 PYTHON_DEPENDENCIES += readline
 else
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/python: add optional support for libintl
  2017-03-12 14:06 [Buildroot] [PATCH 1/1] package/python: add optional support for libintl Bernd Kuhls
@ 2017-03-12 15:07 ` Thomas Petazzoni
  2017-03-13 23:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-03-12 15:07 UTC (permalink / raw)
  To: buildroot

Hello,

On Sun, 12 Mar 2017 15:06:05 +0100, Bernd Kuhls wrote:
> Python links to gettext when available:
> 
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/python2.7/lib-dynload/_locale.so | grep NEEDED
>  0x00000001 (NEEDED)                     Shared library: [libintl.so.8]
>  0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
>  0x00000001 (NEEDED)                     Shared library: [libc.so.0]
> 
> In comparison the same library compiled without gettext:
> 
> $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a output/target/usr/lib/python2.7/lib-dynload/_locale.so | grep NEEDED
>  0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
>  0x00000001 (NEEDED)                     Shared library: [libc.so.0]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/python/python.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/python: add optional support for libintl
  2017-03-12 14:06 [Buildroot] [PATCH 1/1] package/python: add optional support for libintl Bernd Kuhls
  2017-03-12 15:07 ` Thomas Petazzoni
@ 2017-03-13 23:25 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-03-13 23:25 UTC (permalink / raw)
  To: buildroot

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Python links to gettext when available:
 > $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a
 > output/target/usr/lib/python2.7/lib-dynload/_locale.so | grep NEEDED
 >  0x00000001 (NEEDED)                     Shared library: [libintl.so.8]
 >  0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
 >  0x00000001 (NEEDED)                     Shared library: [libc.so.0]

 > In comparison the same library compiled without gettext:

 > $ output/host/usr/bin/i586-buildroot-linux-uclibc-readelf -a
 > output/target/usr/lib/python2.7/lib-dynload/_locale.so | grep NEEDED
 >  0x00000001 (NEEDED)                     Shared library: [libpython2.7.so.1.0]
 >  0x00000001 (NEEDED)                     Shared library: [libc.so.0]

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 > ---
 >  package/python/python.mk | 4 ++++
 >  1 file changed, 4 insertions(+)

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-13 23:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-12 14:06 [Buildroot] [PATCH 1/1] package/python: add optional support for libintl Bernd Kuhls
2017-03-12 15:07 ` Thomas Petazzoni
2017-03-13 23:25 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox