Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: add qt5virtualkeyboard
Date: Mon, 20 Mar 2017 15:46:12 +0100	[thread overview]
Message-ID: <20170320154612.0b3a9f6e@free-electrons.com> (raw)
In-Reply-To: <20170320142005.a6jb32nyfdiypdxd@gportay>

Hello,

Thanks for reviewing your own patch :)

On Mon, 20 Mar 2017 10:20:05 -0400, Ga?l PORTAY wrote:

> Also, I am working of installing language layouts.
> 
> For now, Chinese, Korean and Japanese layouts do no work properly; others are
> fined.
> 
> About the integration of a selection of layouts, I cannot make the decision
> between a select or a string kconfig entry. I think the string entry has the
> advantage to not to have to maintain a hardcoded list; this list would evoluate
> between Qt versions...
> 
> Would you prefer a select or a string?

Yes, a string is better, with a default value of having say just
english installed.

Regarding Chinese, Korean and Japanese, if you don't need them, and you
leave them as non-working, it's fine with me. People interested can
always build on top of what you did, and fix the issue with those
languages. We don't require a package that supports all options and
possibilities.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-03-20 14:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 16:46 [Buildroot] [PATCH] package: add qt5virtualkeyboard Gaël PORTAY
2017-03-18 14:22 ` Thomas Petazzoni
2017-03-20 14:20   ` Gaël PORTAY
2017-03-20 14:46     ` Thomas Petazzoni [this message]
2017-03-20 20:33 ` Peter Seiderer
2017-03-21 13:52   ` Gaël PORTAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170320154612.0b3a9f6e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox