From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: add qt5virtualkeyboard
Date: Mon, 20 Mar 2017 21:33:14 +0100 [thread overview]
Message-ID: <20170320213314.394bdb0e@gmx.net> (raw)
In-Reply-To: <20170317164628.5029-1-gael.portay@savoirfairelinux.com>
Hello Ga?l,
some additions to your own findings...
On Fri, 17 Mar 2017 12:46:28 -0400, Ga?l PORTAY <gael.portay@savoirfairelinux.com> wrote:
> This patch adds the Qt virtualkeyboard package.
>
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
> package/qt5/Config.in | 1 +
> package/qt5/qt5virtualkeyboard/Config.in | 9 +++++++
> .../qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk | 31 ++++++++++++++++++++++
> 3 files changed, 41 insertions(+)
> create mode 100644 package/qt5/qt5virtualkeyboard/Config.in
> create mode 100644 package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
>
> diff --git a/package/qt5/Config.in b/package/qt5/Config.in
> index 4bcbc6e..a810503 100644
> --- a/package/qt5/Config.in
> +++ b/package/qt5/Config.in
> @@ -76,6 +76,7 @@ source "package/qt5/qt5serialbus/Config.in"
> source "package/qt5/qt5serialport/Config.in"
> source "package/qt5/qt5svg/Config.in"
> source "package/qt5/qt5tools/Config.in"
> +source "package/qt5/qt5virtualkeyboard/Config.in"
> source "package/qt5/qt5webchannel/Config.in"
> source "package/qt5/qt5webkit/Config.in"
> source "package/qt5/qt5websockets/Config.in"
> diff --git a/package/qt5/qt5virtualkeyboard/Config.in b/package/qt5/qt5virtualkeyboard/Config.in
> new file mode 100644
> index 0000000..df9e9d6
> --- /dev/null
> +++ b/package/qt5/qt5virtualkeyboard/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_QT5VIRTUALKEYBOARD
> + bool "qt5virtualkeyboard"
Needs
depends on BR2_PACKAGE_QT5_VERSION_LATEST
or some non-standard download location in case qt5virtualkeyboard is although
availabe for qt-5.6.2?
> + depends on BR2_PACKAGE_QT5DECLARATIVE_QUICK
> + select BR2_PACKAGE_QT5SVG
> + help
> + Qt Virtual Keyboard is a virtual keyboard framework that consists of a
> + C++ backend supporting custom input methods as well as a UI frontend
> + implemented in QML.
> +
Maybe mention the GPLv3 only license here?
And some comment in case the dependencies are not given:
comment "qt5virtualkeyboard needs at least qt-5.8.0 and qt5declarative quick module"
depends on !BR2_PACKAGE_QT5_VERSION_LATEST || !BR2_PACKAGE_QT5DECLARATIVE_QUICK
Regards,
Peter
> diff --git a/package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk b/package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
> new file mode 100644
> index 0000000..e73a154
> --- /dev/null
> +++ b/package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
> @@ -0,0 +1,31 @@
> +################################################################################
> +#
> +# qt5virtualkeyboard
> +#
> +################################################################################
> +
> +QT5VIRTUALKEYBOARD_VERSION = $(QT5_VERSION)
> +QT5VIRTUALKEYBOARD_SITE = $(QT5_SITE)
> +QT5VIRTUALKEYBOARD_SOURCE = qtvirtualkeyboard-opensource-src-$(QT5VIRTUALKEYBOARD_VERSION).tar.xz
> +QT5VIRTUALKEYBOARD_DEPENDENCIES = qt5base qt5declarative qt5svg
> +QT5VIRTUALKEYBOARD_INSTALL_STAGING = YES
> +
> +QT5VIRTUALKEYBOARD_LICENSE = GPLv3
> +QT5VIRTUALKEYBOARD_LICENSE_FILES = LICENSE.GPL3
> +define QT5VIRTUALKEYBOARD_CONFIGURE_CMDS
> + (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
> +endef
> +
> +define QT5VIRTUALKEYBOARD_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define QT5VIRTUALKEYBOARD_INSTALL_STAGING_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
> +endef
> +
> +define QT5VIRTUALKEYBOARD_INSTALL_TARGET_CMDS
> + cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick/VirtualKeyboard $(TARGET_DIR)/usr/qml/QtQuick
> +endef
> +
> +$(eval $(generic-package))
next prev parent reply other threads:[~2017-03-20 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 16:46 [Buildroot] [PATCH] package: add qt5virtualkeyboard Gaël PORTAY
2017-03-18 14:22 ` Thomas Petazzoni
2017-03-20 14:20 ` Gaël PORTAY
2017-03-20 14:46 ` Thomas Petazzoni
2017-03-20 20:33 ` Peter Seiderer [this message]
2017-03-21 13:52 ` Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320213314.394bdb0e@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox