Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] mesa3d: drop unneeded libsha1 logic from Config.in
@ 2017-03-28 12:30 Peter Korsgaard
  2017-03-28 19:44 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2017-03-28 12:30 UTC (permalink / raw)
  To: buildroot

Commit 7f4e9490b647 (package/mesa3d: remove sha1 external dependency)
removed the --with-sha1 logic from mesa3d.mk, but didn't remove the
corresponding logic / comment from Config.in.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/mesa3d/Config.in | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 2b085ab59..57e88ec66 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -153,10 +153,6 @@ config BR2_PACKAGE_MESA3D_VULKAN_DRIVER_INTEL
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18 # memfd.h
 	depends on BR2_TOOLCHAIN_USES_GLIBC # ifunc, static_assert
 	depends on BR2_PACKAGE_XORG7 # xproto_dri3proto
-	# We need a SHA1 implementation. If either openssl or
-	# libgcrypt are already part of the build, we'll use one of
-	# them, otherwise, use the small libsha1 library.
-	select BR2_PACKAGE_LIBSHA1 if (!BR2_PACKAGE_OPENSSL && !BR2_PACKAGE_LIBGCRYPT)
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER_I965
 	select BR2_PACKAGE_MESA3D_VULKAN_DRIVER
 	select BR2_PACKAGE_XPROTO_DRI3PROTO
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] mesa3d: drop unneeded libsha1 logic from Config.in
  2017-03-28 12:30 [Buildroot] [PATCH] mesa3d: drop unneeded libsha1 logic from Config.in Peter Korsgaard
@ 2017-03-28 19:44 ` Thomas Petazzoni
  2017-03-28 19:49   ` Romain Naour
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2017-03-28 19:44 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 28 Mar 2017 14:30:21 +0200, Peter Korsgaard wrote:
> Commit 7f4e9490b647 (package/mesa3d: remove sha1 external dependency)
> removed the --with-sha1 logic from mesa3d.mk, but didn't remove the
> corresponding logic / comment from Config.in.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/mesa3d/Config.in | 4 ----
>  1 file changed, 4 deletions(-)

Applied to master, thanks. Good catch!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] mesa3d: drop unneeded libsha1 logic from Config.in
  2017-03-28 19:44 ` Thomas Petazzoni
@ 2017-03-28 19:49   ` Romain Naour
  0 siblings, 0 replies; 3+ messages in thread
From: Romain Naour @ 2017-03-28 19:49 UTC (permalink / raw)
  To: buildroot

Hi Peter, All,

Le 28/03/2017 ? 21:44, Thomas Petazzoni a ?crit :
> Hello,
> 
> On Tue, 28 Mar 2017 14:30:21 +0200, Peter Korsgaard wrote:
>> Commit 7f4e9490b647 (package/mesa3d: remove sha1 external dependency)
>> removed the --with-sha1 logic from mesa3d.mk, but didn't remove the
>> corresponding logic / comment from Config.in.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>>  package/mesa3d/Config.in | 4 ----
>>  1 file changed, 4 deletions(-)
> 
> Applied to master, thanks. Good catch!

Back on line too late to ack this patch :p

Thanks!

Romain

> 
> Thomas
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-28 19:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-28 12:30 [Buildroot] [PATCH] mesa3d: drop unneeded libsha1 logic from Config.in Peter Korsgaard
2017-03-28 19:44 ` Thomas Petazzoni
2017-03-28 19:49   ` Romain Naour

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox