* [Buildroot] [PATCH] package/lensfun: fix static only build
@ 2017-03-31 21:32 Romain Naour
2017-04-01 11:57 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Romain Naour @ 2017-03-31 21:32 UTC (permalink / raw)
To: buildroot
Build lensfun.a for static only build.
Fixes:
http://autobuild.buildroot.net/results/63e/63e7700a242c7c28ede0fe0b6a63db288e73e974/build-end.log
Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
package/lensfun/lensfun.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/lensfun/lensfun.mk b/package/lensfun/lensfun.mk
index 8e92e59..fa002c7 100644
--- a/package/lensfun/lensfun.mk
+++ b/package/lensfun/lensfun.mk
@@ -34,6 +34,12 @@ else
LENSFUN_CONF_OPTS += -DBUILD_LENSTOOL=OFF
endif
+ifeq ($(BR2_STATIC_LIBS),y)
+LENSFUN_CONF_OPTS += -DBUILD_STATIC=ON
+else
+LENSFUN_CONF_OPTS += -DBUILD_STATIC=OFF
+endif
+
# Don't install helper scripts (which require python3 and gksudo).
# Don't run setup.py on the host.
LENSFUN_CONF_OPTS += -DINSTALL_HELPER_SCRIPTS=OFF -DPYTHON=OFF
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/lensfun: fix static only build
2017-03-31 21:32 [Buildroot] [PATCH] package/lensfun: fix static only build Romain Naour
@ 2017-04-01 11:57 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-04-01 11:57 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 31 Mar 2017 23:32:49 +0200, Romain Naour wrote:
> Build lensfun.a for static only build.
>
> Fixes:
> http://autobuild.buildroot.net/results/63e/63e7700a242c7c28ede0fe0b6a63db288e73e974/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/lensfun/lensfun.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
I was a little bit confused at first, because we normally want the
static library either in the BR2_STATIC_LIBS or BR2_SHARED_STATIC_LIBS
case. But lensfun build system only allows to build either the shared
library *OR* the static library, not both, so what you did is I believe
the best solution.
Therefore: applied, thanks!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-01 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-31 21:32 [Buildroot] [PATCH] package/lensfun: fix static only build Romain Naour
2017-04-01 11:57 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox