From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpir: new package
Date: Thu, 13 Apr 2017 21:59:59 +0200 [thread overview]
Message-ID: <20170413215959.6e221b3e@free-electrons.com> (raw)
In-Reply-To: <1492091374-5028-1-git-send-email-semenak94@mail.ru>
Hello,
On Thu, 13 Apr 2017 16:49:34 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
Thanks for this new contribution. It generally looks good, just a few
comments, see below.
> package/Config.in | 1 +
> package/mpir/Config.in | 8 ++++++++
> package/mpir/mpir.hash | 2 ++
> package/mpir/mpir.mk | 18 ++++++++++++++++++
You forgot to change the DEVELOPERS file to add yourself as the
developer for this package.
> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
> new file mode 100644
> index 0000000..fbce887
> --- /dev/null
> +++ b/package/mpir/mpir.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# mpir
> +#
> +################################################################################
> +
> +MPIR_VERSION = 3.0.0
> +MPIR_SITE = http://www.mpir.org
> +MPIR_SOURCE = mpir-$(MPIR_VERSION).tar.bz2
> +MPIR_LICENSE = LGPL-3.0+
> +MPIR_LICENSE_FILES = COPYING.LIB
> +MPIR_INSTALL_STAGING = YES
> +MPIR_DEPENDENCIES = gmp
> +HOST_MPIR_DEPENDENCIES = host-gmp
> +MPIR_MAKE_OPTS = RANLIB=$(TARGET_RANLIB)
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
Why is a host variant of this package needed? It should at the very
least be explained in the commit log.
The rest looks good.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-13 19:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mpir: new package>
2017-04-13 13:49 ` [Buildroot] [PATCH] mpir: new package Semyon Kolganov
2017-04-13 19:59 ` Thomas Petazzoni [this message]
[not found] ` <1492114114.644630127@f341.i.mail.ru>
2017-04-13 20:13 ` Thomas Petazzoni
2017-04-13 20:32 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-13 21:05 ` Thomas Petazzoni
[not found] <mpir: fix build failure>
2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
2017-04-17 14:08 ` Yann E. MORIN
2017-04-17 14:20 ` Semen Kolganov
2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-17 14:57 ` Yann E. MORIN
2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
2017-04-18 19:59 ` Arnout Vandecappelle
2017-04-19 9:12 ` [Buildroot] [PATCHv4] mpir: fix build failure Semyon Kolganov
2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
2017-05-01 9:21 ` Thomas Petazzoni
2017-05-01 9:25 ` Thomas Petazzoni
2017-05-01 19:40 ` semenak94 at mail.ru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413215959.6e221b3e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox