Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] mpir: fix build failure
Date: Mon, 17 Apr 2017 16:57:05 +0200	[thread overview]
Message-ID: <20170417145705.GC3441@scaer> (raw)
In-Reply-To: <1492440040-1709-1-git-send-email-semenak94@mail.ru>

Semyon, All,

On 2017-04-17 17:40 +0300, Semyon Kolganov spake thusly:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

I forgot to state in my previous review, but: is this fixing autobuilder
failiures? If so, please include (a few) references to those failures,
like (assuming those are the failures you wanted to fix!):

    Fixes:
        http://autobuild.buildroot.org/results/df7/df7e532686303e8f975aefc82dafb9ee66c529c8/
        http://autobuild.buildroot.org/results/a9a/a9a1f0a23f8983410cf641d869ad0dcd543da677/
        [...]

I guess the committer can add this when applying; no need to respin.

Otherwise:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> Changes between v1 and v2:
>  - removed unneeded depend on
>  - fixed build for powerpc
> ---
>  package/mpir/mpir.mk | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
> index 430d587..2a5807b 100644
> --- a/package/mpir/mpir.mk
> +++ b/package/mpir/mpir.mk
> @@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB
>  MPIR_INSTALL_STAGING = YES
>  MPIR_DEPENDENCIES = gmp host-yasm
>  
> +ifeq ($(BR2_MIPS_NABI32),y)
> +MPIR_CONF_OPTS += ABI=n32
> +endif
> +
> +ifeq ($(BR2_MIPS_NABI64),y)
> +MPIR_CONF_OPTS += ABI=n64
> +endif
> +
> +ifeq ($(BR2_powerpc_CLASSIC),y)
> +MPIR_CONF_OPTS += ABI=mode64
> +export MPN_PATH=generic
> +endif
> +
>  $(eval $(autotools-package))
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-04-17 14:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mpir: fix build failure>
2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
2017-04-17 14:08   ` Yann E. MORIN
2017-04-17 14:20     ` Semen Kolganov
2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-17 14:57   ` Yann E. MORIN [this message]
2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
2017-04-18 19:59   ` Arnout Vandecappelle
2017-04-19  9:12 ` [Buildroot] [PATCHv4] mpir: fix build failure Semyon Kolganov
2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
2017-05-01  9:21   ` Thomas Petazzoni
2017-05-01  9:25     ` Thomas Petazzoni
2017-05-01 19:40     ` semenak94 at mail.ru
     [not found] <mpir: new package>
2017-04-13 13:49 ` [Buildroot] [PATCH] mpir: new package Semyon Kolganov
2017-04-13 19:59   ` Thomas Petazzoni
     [not found]     ` <1492114114.644630127@f341.i.mail.ru>
2017-04-13 20:13       ` Thomas Petazzoni
2017-04-13 20:32 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-13 21:05   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170417145705.GC3441@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox