[Buildroot] [PATCH] gtest: fix usage on ARM platforms

[Buildroot] [PATCH] gtest: fix usage on ARM platforms

[Carlos Santos]

Ensure that GTest is compiled with -fPIC to allow linking the static
libraries with dynamically linked programs. This is not a requirement
for most architectures but is mandatory for ARM.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
---
 package/gtest/gtest.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gtest/gtest.mk b/package/gtest/gtest.mk
index 329179d..dc43597 100644
--- a/package/gtest/gtest.mk
+++ b/package/gtest/gtest.mk
@@ -37,6 +37,13 @@ HOST_GTEST_GMOCK_PYTHONPATH = \
 # the gtest sources.
 GTEST_CONF_OPTS = -DBUILD_SHARED_LIBS=OFF
 
+# Ensure that GTest is compiled with -fPIC to allow linking the static
+# libraries with dynamically linked programs. This is not a requirement
+# for most architectures but is mandatory for ARM.
+ifeq ($(BR2_STATIC_LIBS),)
+GTEST_CONF_OPTS += -DCMAKE_POSITION_INDEPENDENT_CODE=ON
+endif
+
 GTEST_CONF_OPTS += -DBUILD_GTEST=ON
 
 ifeq ($(BR2_PACKAGE_GTEST_GMOCK),y)
-- 
2.7.4

[Buildroot] [PATCH] gtest: fix usage on ARM platforms

[Thomas Petazzoni]

Hello,

On Wed, 19 Apr 2017 08:51:52 -0300, Carlos Santos wrote:
> Ensure that GTest is compiled with -fPIC to allow linking the static
> libraries with dynamically linked programs. This is not a requirement
> for most architectures but is mandatory for ARM.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>

Is this fixing an autobuilder issue? If so, the reference to the
autobuilder failure should be included in the commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH] gtest: fix usage on ARM platforms

[Carlos Santos]

> From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
> To: "Carlos Santos" <casantos@datacom.ind.br>
> Cc: buildroot at buildroot.org
> Sent: Wednesday, April 19, 2017 9:33:31 AM
> Subject: Re: [Buildroot] [PATCH] gtest: fix usage on ARM platforms

> Hello,
> 
> On Wed, 19 Apr 2017 08:51:52 -0300, Carlos Santos wrote:
>> Ensure that GTest is compiled with -fPIC to allow linking the static
>> libraries with dynamically linked programs. This is not a requirement
>> for most architectures but is mandatory for ARM.
>> 
>> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> 
> Is this fixing an autobuilder issue? If so, the reference to the
> autobuilder failure should be included in the commit log.

It was observed during a local build of one of our products which
has an ARM Cortex-A9 processor.

-- 
Carlos Santos (Casantos) - DATACOM, P&D
?The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.? ? Christopher Hitchens

[Buildroot] [PATCH] gtest: fix usage on ARM platforms

[Thomas Petazzoni]

Hello,

On Wed, 19 Apr 2017 08:51:52 -0300, Carlos Santos wrote:
> Ensure that GTest is compiled with -fPIC to allow linking the static
> libraries with dynamically linked programs. This is not a requirement
> for most architectures but is mandatory for ARM.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> ---
>  package/gtest/gtest.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com