* [Buildroot] [PATCH] xorriso: disable libcdio
@ 2017-04-22 20:10 Baruch Siach
2017-04-24 4:41 ` Steve Kenton
2017-04-26 8:02 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2017-04-22 20:10 UTC (permalink / raw)
To: buildroot
xorriso and libcdio define identically named symbols. This breaks static
linking.
Besides, upstream suggested that on Linux the built-in libburn adapter is much
better tested than libcdio.
Disable libcdio.
Fixes:
http://autobuild.buildroot.net/results/430/430a6b548fcc311f20ea71cecaa11fafac1d5a19/
http://autobuild.buildroot.net/results/a5d/a5d0f8bec0d39e48f6dfe4ecc07fe0ca3c6bd70a/
Cc: Steve Kenton <skenton@ou.edu>
Suggested-by: Thomas Schmitt <scdbackup@gmx.net>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/xorriso/xorriso.mk | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
index b2055804302e..1f095911f80f 100644
--- a/package/xorriso/xorriso.mk
+++ b/package/xorriso/xorriso.mk
@@ -18,19 +18,14 @@ HOST_XORRISO_CONF_OPTS = \
--disable-libedit \
--disable-libacl
+# libcdio doesn't make sense for Linux
+# http://lists.gnu.org/archive/html/bug-xorriso/2017-04/msg00004.html
+XORRISO_CONF_OPTS = --disable-libcdio
+
ifeq ($(BR2_PACKAGE_LIBICONV),y)
XORRISO_DEPENDENCIES += libiconv
endif
-ifeq ($(BR2_PACKAGE_LIBCDIO),y)
-XORRISO_DEPENDENCIES += host-pkgconf libcdio
-XORRISO_CONF_OPTS += \
- --enable-pkg-check-modules \
- --enable-libcdio
-else
-XORRISO_CONF_OPTS += --disable-libcdio
-endif
-
ifeq ($(BR2_PACKAGE_READLINE),y)
XORRISO_DEPENDENCIES += readline
XORRISO_CONF_OPTS += --enable-libreadline
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] xorriso: disable libcdio
2017-04-22 20:10 [Buildroot] [PATCH] xorriso: disable libcdio Baruch Siach
@ 2017-04-24 4:41 ` Steve Kenton
2017-04-24 4:57 ` Baruch Siach
2017-04-26 8:02 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Steve Kenton @ 2017-04-24 4:41 UTC (permalink / raw)
To: buildroot
Looks good to me
Ack - Steve Kenton
On 04/22/2017 08:10 PM, Baruch Siach wrote:
> xorriso and libcdio define identically named symbols. This breaks static
> linking.
>
> Besides, upstream suggested that on Linux the built-in libburn adapter is much
> better tested than libcdio.
>
> Disable libcdio.
>
> Fixes:
> http://autobuild.buildroot.net/results/430/430a6b548fcc311f20ea71cecaa11fafac1d5a19/
> http://autobuild.buildroot.net/results/a5d/a5d0f8bec0d39e48f6dfe4ecc07fe0ca3c6bd70a/
>
> Cc: Steve Kenton <skenton@ou.edu>
> Suggested-by: Thomas Schmitt <scdbackup@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/xorriso/xorriso.mk | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
> index b2055804302e..1f095911f80f 100644
> --- a/package/xorriso/xorriso.mk
> +++ b/package/xorriso/xorriso.mk
> @@ -18,19 +18,14 @@ HOST_XORRISO_CONF_OPTS = \
> --disable-libedit \
> --disable-libacl
>
> +# libcdio doesn't make sense for Linux
> +# http://lists.gnu.org/archive/html/bug-xorriso/2017-04/msg00004.html
> +XORRISO_CONF_OPTS = --disable-libcdio
> +
> ifeq ($(BR2_PACKAGE_LIBICONV),y)
> XORRISO_DEPENDENCIES += libiconv
> endif
>
> -ifeq ($(BR2_PACKAGE_LIBCDIO),y)
> -XORRISO_DEPENDENCIES += host-pkgconf libcdio
> -XORRISO_CONF_OPTS += \
> - --enable-pkg-check-modules \
> - --enable-libcdio
> -else
> -XORRISO_CONF_OPTS += --disable-libcdio
> -endif
> -
> ifeq ($(BR2_PACKAGE_READLINE),y)
> XORRISO_DEPENDENCIES += readline
> XORRISO_CONF_OPTS += --enable-libreadline
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] xorriso: disable libcdio
2017-04-24 4:41 ` Steve Kenton
@ 2017-04-24 4:57 ` Baruch Siach
0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2017-04-24 4:57 UTC (permalink / raw)
To: buildroot
Hi Steve,
On Mon, Apr 24, 2017 at 04:41:23AM +0000, Steve Kenton wrote:
> Looks good to me
>
> Ack - Steve Kenton
Thanks.
I'll repeat your ack below in a format that patchwork understands:
Acked-by: Steve Kenton <skenton@ou.edu>
The ack should be visible at http://patchwork.ozlabs.org/patch/753835/.
baruch
> On 04/22/2017 08:10 PM, Baruch Siach wrote:
> > xorriso and libcdio define identically named symbols. This breaks static
> > linking.
> >
> > Besides, upstream suggested that on Linux the built-in libburn adapter is much
> > better tested than libcdio.
> >
> > Disable libcdio.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/430/430a6b548fcc311f20ea71cecaa11fafac1d5a19/
> > http://autobuild.buildroot.net/results/a5d/a5d0f8bec0d39e48f6dfe4ecc07fe0ca3c6bd70a/
> >
> > Cc: Steve Kenton <skenton@ou.edu>
> > Suggested-by: Thomas Schmitt <scdbackup@gmx.net>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/xorriso/xorriso.mk | 13 ++++---------
> > 1 file changed, 4 insertions(+), 9 deletions(-)
> >
> > diff --git a/package/xorriso/xorriso.mk b/package/xorriso/xorriso.mk
> > index b2055804302e..1f095911f80f 100644
> > --- a/package/xorriso/xorriso.mk
> > +++ b/package/xorriso/xorriso.mk
> > @@ -18,19 +18,14 @@ HOST_XORRISO_CONF_OPTS = \
> > --disable-libedit \
> > --disable-libacl
> > +# libcdio doesn't make sense for Linux
> > +# http://lists.gnu.org/archive/html/bug-xorriso/2017-04/msg00004.html
> > +XORRISO_CONF_OPTS = --disable-libcdio
> > +
> > ifeq ($(BR2_PACKAGE_LIBICONV),y)
> > XORRISO_DEPENDENCIES += libiconv
> > endif
> > -ifeq ($(BR2_PACKAGE_LIBCDIO),y)
> > -XORRISO_DEPENDENCIES += host-pkgconf libcdio
> > -XORRISO_CONF_OPTS += \
> > - --enable-pkg-check-modules \
> > - --enable-libcdio
> > -else
> > -XORRISO_CONF_OPTS += --disable-libcdio
> > -endif
> > -
> > ifeq ($(BR2_PACKAGE_READLINE),y)
> > XORRISO_DEPENDENCIES += readline
> > XORRISO_CONF_OPTS += --enable-libreadline
>
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] xorriso: disable libcdio
2017-04-22 20:10 [Buildroot] [PATCH] xorriso: disable libcdio Baruch Siach
2017-04-24 4:41 ` Steve Kenton
@ 2017-04-26 8:02 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-04-26 8:02 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 22 Apr 2017 23:10:44 +0300, Baruch Siach wrote:
> xorriso and libcdio define identically named symbols. This breaks static
> linking.
>
> Besides, upstream suggested that on Linux the built-in libburn adapter is much
> better tested than libcdio.
>
> Disable libcdio.
>
> Fixes:
> http://autobuild.buildroot.net/results/430/430a6b548fcc311f20ea71cecaa11fafac1d5a19/
> http://autobuild.buildroot.net/results/a5d/a5d0f8bec0d39e48f6dfe4ecc07fe0ca3c6bd70a/
>
> Cc: Steve Kenton <skenton@ou.edu>
> Suggested-by: Thomas Schmitt <scdbackup@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/xorriso/xorriso.mk | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-26 8:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-22 20:10 [Buildroot] [PATCH] xorriso: disable libcdio Baruch Siach
2017-04-24 4:41 ` Steve Kenton
2017-04-24 4:57 ` Baruch Siach
2017-04-26 8:02 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox