* [Buildroot] libcurl: propagate buildroot debugging option
@ 2017-04-25 15:42 Olivier Valentin
2017-04-29 14:18 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Olivier Valentin @ 2017-04-25 15:42 UTC (permalink / raw)
To: buildroot
When buildroot has debugging enabled, let libcurl configure
its build accordingly.
Signed-off-by: Olivier Valentin <ovalentin@awox.com>
---
package/libcurl/libcurl.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk
index 6f4803e0c..cba771c61 100644
--- a/package/libcurl/libcurl.mk
+++ b/package/libcurl/libcurl.mk
@@ -22,6 +22,10 @@ LIBCURL_INSTALL_STAGING = YES
LIBCURL_CONF_OPTS = --disable-manual --disable-ntlm-wb \
--enable-hidden-symbols --with-random=/dev/urandom
--disable-curldebug
+ifeq ($(BR2_ENABLE_DEBUG),y)
+LIBCURL_CONF_OPTS += --enable-debug
+endif
+
ifeq ($(BR2_PACKAGE_LIBCURL_VERBOSE),y)
LIBCURL_CONF_OPTS += --enable-verbose
else
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Buildroot] libcurl: propagate buildroot debugging option
2017-04-25 15:42 [Buildroot] libcurl: propagate buildroot debugging option Olivier Valentin
@ 2017-04-29 14:18 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-04-29 14:18 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 25 Apr 2017 17:42:16 +0200, Olivier Valentin wrote:
> When buildroot has debugging enabled, let libcurl configure
> its build accordingly.
>
> Signed-off-by: Olivier Valentin <ovalentin@awox.com>
Thanks, but since commit
https://git.buildroot.org/buildroot/commit/?id=0552a367dbdc27a211daaac3359d81dd537e384f,
we no longer pass --enable-debug/--disable-debug to packages. Indeed,
we have realized that packages are not consistent in what they do when
--enable-debug/--disable-debug is passed.
So, BR2_ENABLE_DEBUG is nowadays *only* to get packages built with
debugging symbols, and this is controlled by adding "-g" to CFLAGS.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-29 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 15:42 [Buildroot] libcurl: propagate buildroot debugging option Olivier Valentin
2017-04-29 14:18 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox