Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] x11vnc: make x11vnc select libvncserver
Date: Sun, 30 Apr 2017 15:05:02 +0200	[thread overview]
Message-ID: <20170430130502.32345-1-martink@posteo.de> (raw)
In-Reply-To: <20170430084350.zpxjcn7y6ws4w4lf@sapphire.tkos.co.il>

x11vnc needs libvncserver, so select it explicitely.

In case of missing libvncserver, we see build failures like this:

http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---

Thanks a lot for your help! I think that's what you meant, right?

revision history
----------------
v2: add libvncserver to build dependencies and !BR2_nios2 to depends
v1: initial patch. add select BR2_PACKAGE_LIBVNCSERVER


 package/x11vnc/Config.in | 2 ++
 package/x11vnc/x11vnc.mk | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/package/x11vnc/Config.in b/package/x11vnc/Config.in
index 0909b9aec..9d9541cbf 100644
--- a/package/x11vnc/Config.in
+++ b/package/x11vnc/Config.in
@@ -2,9 +2,11 @@ config BR2_PACKAGE_X11VNC
 	bool "x11vnc"
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_nios2 # from libvncserver
 	select BR2_PACKAGE_XLIB_LIBXT
 	select BR2_PACKAGE_XLIB_LIBXEXT
 	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_LIBVNCSERVER
 	help
 	  VNC server for X11 display
 
diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
index 9233b7047..5a505b920 100644
--- a/package/x11vnc/x11vnc.mk
+++ b/package/x11vnc/x11vnc.mk
@@ -16,6 +16,8 @@ X11VNC_LICENSE_FILES = COPYING
 # Source coming from github, no configure included
 X11VNC_AUTORECONF = YES
 
+X11VNC_DEPENDENCIES += libvncserver
+
 ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy)
 X11VNC_DEPENDENCIES += avahi dbus
 else
-- 
2.11.0

  reply	other threads:[~2017-04-30 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30  8:35 [Buildroot] [PATCH] x11vnc: make x11vnc select libvncserver Martin Kepplinger
2017-04-30  8:43 ` Baruch Siach
2017-04-30 13:05   ` Martin Kepplinger [this message]
2017-04-30 21:03     ` [Buildroot] [PATCH v2] " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170430130502.32345-1-martink@posteo.de \
    --to=martink@posteo.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox