From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] x11vnc: make x11vnc select libvncserver
Date: Sun, 30 Apr 2017 23:03:58 +0200 [thread overview]
Message-ID: <20170430230358.1cd5d582@free-electrons.com> (raw)
In-Reply-To: <20170430130502.32345-1-martink@posteo.de>
Hello,
On Sun, 30 Apr 2017 15:05:02 +0200, Martin Kepplinger wrote:
> diff --git a/package/x11vnc/Config.in b/package/x11vnc/Config.in
> index 0909b9aec..9d9541cbf 100644
> --- a/package/x11vnc/Config.in
> +++ b/package/x11vnc/Config.in
> @@ -2,9 +2,11 @@ config BR2_PACKAGE_X11VNC
> bool "x11vnc"
> depends on BR2_PACKAGE_XORG7
> depends on BR2_USE_MMU # fork()
> + depends on !BR2_nios2 # from libvncserver
The comment is normally just "# libvncserver"
> select BR2_PACKAGE_XLIB_LIBXT
> select BR2_PACKAGE_XLIB_LIBXEXT
> select BR2_PACKAGE_XLIB_LIBXTST
> + select BR2_PACKAGE_LIBVNCSERVER
We try to keep things sorted alphabetically, so this select should have
been before the other ones.
> diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
> index 9233b7047..5a505b920 100644
> --- a/package/x11vnc/x11vnc.mk
> +++ b/package/x11vnc/x11vnc.mk
> @@ -16,6 +16,8 @@ X11VNC_LICENSE_FILES = COPYING
> # Source coming from github, no configure included
> X11VNC_AUTORECONF = YES
>
> +X11VNC_DEPENDENCIES += libvncserver
No need for a new X11VNC_DEPENDENCIES assignment here, there was
already one a few lines above.
I've fixed those minor issues and applied your patch. Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-04-30 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 8:35 [Buildroot] [PATCH] x11vnc: make x11vnc select libvncserver Martin Kepplinger
2017-04-30 8:43 ` Baruch Siach
2017-04-30 13:05 ` [Buildroot] [PATCH v2] " Martin Kepplinger
2017-04-30 21:03 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430230358.1cd5d582@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox