* [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs
@ 2017-04-30 12:35 J Evans
2017-04-30 17:14 ` Yann E. MORIN
2017-04-30 17:33 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: J Evans @ 2017-04-30 12:35 UTC (permalink / raw)
To: buildroot
Signed-off-by: J Evans <g4@novadsp.com>
---
fs/ext2/ext2.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
index 30f1d17..9d3e8fd 100644
--- a/fs/ext2/ext2.mk
+++ b/fs/ext2/ext2.mk
@@ -6,9 +6,7 @@
EXT2_OPTS = -G $(BR2_TARGET_ROOTFS_EXT2_GEN) -R $(BR2_TARGET_ROOTFS_EXT2_REV)
-ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
-endif
ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs
2017-04-30 12:35 [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs J Evans
@ 2017-04-30 17:14 ` Yann E. MORIN
2017-04-30 17:33 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2017-04-30 17:14 UTC (permalink / raw)
To: buildroot
J, All,
On 2017-04-30 13:35 +0100, J Evans spake thusly:
> Signed-off-by: J Evans <g4@novadsp.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Thanks! :-)
Regards,
Yann E. MORIN.
> ---
> fs/ext2/ext2.mk | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
> index 30f1d17..9d3e8fd 100644
> --- a/fs/ext2/ext2.mk
> +++ b/fs/ext2/ext2.mk
> @@ -6,9 +6,7 @@
>
> EXT2_OPTS = -G $(BR2_TARGET_ROOTFS_EXT2_GEN) -R $(BR2_TARGET_ROOTFS_EXT2_REV)
>
> -ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
> EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
> -endif
>
> ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
> EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs
2017-04-30 12:35 [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs J Evans
2017-04-30 17:14 ` Yann E. MORIN
@ 2017-04-30 17:33 ` Thomas Petazzoni
2017-04-30 19:43 ` Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-04-30 17:33 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 30 Apr 2017 13:35:47 +0100, J Evans wrote:
> Signed-off-by: J Evans <g4@novadsp.com>
> ---
> fs/ext2/ext2.mk | 2 --
> 1 file changed, 2 deletions(-)
Applied to master, thanks.
However, I believe we should do the same for the number of inodes:
ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
endif
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs
2017-04-30 17:33 ` Thomas Petazzoni
@ 2017-04-30 19:43 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2017-04-30 19:43 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2017-04-30 19:33 +0200, Thomas Petazzoni spake thusly:
> On Sun, 30 Apr 2017 13:35:47 +0100, J Evans wrote:
> > Signed-off-by: J Evans <g4@novadsp.com>
> > ---
> > fs/ext2/ext2.mk | 2 --
> > 1 file changed, 2 deletions(-)
>
> Applied to master, thanks.
>
> However, I believe we should do the same for the number of inodes:
>
> ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
> EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
> endif
Yep, was going to work on that next...
Regards,
Yann E. MORIN.
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-30 19:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-30 12:35 [Buildroot] [PATCH 1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs J Evans
2017-04-30 17:14 ` Yann E. MORIN
2017-04-30 17:33 ` Thomas Petazzoni
2017-04-30 19:43 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox