* [Buildroot] [PATCH] package/kodi: re-install prompt for optical drives
@ 2017-04-17 14:06 Yann E. MORIN
2017-04-21 13:10 ` Bernd Kuhls
2017-05-01 8:53 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2017-04-17 14:06 UTC (permalink / raw)
To: buildroot
In 81c438aa (package/kodi: Rework audio encoder support), the prompt for
the optical drive support was dropped, on the assumption that such
support was only needed when an audio encoder was enabled.
However, support for optical drives is also required when, surprisingly,
one wants to read a DVD (and probably a BD as well, but this was not
tested by lack of hardware).
Re-instate the prompt, so one can enable optical drive support even when
no audio encoder enabled.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
package/kodi/Config.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index f2a3e2e032..b993ac94a5 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -253,7 +253,9 @@ config BR2_PACKAGE_KODI_UPNP
Enable UPnP support
config BR2_PACKAGE_KODI_OPTICALDRIVE
- bool
+ bool "optical drives"
+ help
+ Add support for optical drives, to read e.g. DVDs...
menu "Audio decoder addons"
source "package/kodi-audiodecoder-modplug/Config.in"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/kodi: re-install prompt for optical drives
2017-04-17 14:06 [Buildroot] [PATCH] package/kodi: re-install prompt for optical drives Yann E. MORIN
@ 2017-04-21 13:10 ` Bernd Kuhls
2017-05-01 8:53 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2017-04-21 13:10 UTC (permalink / raw)
To: buildroot
Am Mon, 17 Apr 2017 16:06:41 +0200 schrieb Yann E. MORIN:
> In 81c438aa (package/kodi: Rework audio encoder support), the prompt for
> the optical drive support was dropped, on the assumption that such
> support was only needed when an audio encoder was enabled.
Acked-by: Bernd Kuhls <bernd.kuhls@t-online.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/kodi: re-install prompt for optical drives
2017-04-17 14:06 [Buildroot] [PATCH] package/kodi: re-install prompt for optical drives Yann E. MORIN
2017-04-21 13:10 ` Bernd Kuhls
@ 2017-05-01 8:53 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-05-01 8:53 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Apr 2017 16:06:41 +0200, Yann E. MORIN wrote:
> In 81c438aa (package/kodi: Rework audio encoder support), the prompt for
> the optical drive support was dropped, on the assumption that such
> support was only needed when an audio encoder was enabled.
>
> However, support for optical drives is also required when, surprisingly,
> one wants to read a DVD (and probably a BD as well, but this was not
> tested by lack of hardware).
>
> Re-instate the prompt, so one can enable optical drive support even when
> no audio encoder enabled.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> package/kodi/Config.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-01 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-17 14:06 [Buildroot] [PATCH] package/kodi: re-install prompt for optical drives Yann E. MORIN
2017-04-21 13:10 ` Bernd Kuhls
2017-05-01 8:53 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox