From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] core: allow having a list of "cmake" candidates
Date: Fri, 5 May 2017 23:09:28 +0200 [thread overview]
Message-ID: <20170505210928.GB3001@scaer> (raw)
In-Reply-To: <1494016231-50639-3-git-send-email-casantos@datacom.ind.br>
Carlos, All,
On 2017-05-05 17:30 -0300, Carlos Santos spake thusly:
> Add the BR2_CMAKE_CANDIDATES variable, containing a list of candidates
> to check and use as BR2_CMAKE, if possible.
>
> This allows using "cmake3" on CentOS 7, whose default cmake corresponds
> to version 2.8.12. Example:
>
> $ make BR2_CMAKE_CANDIDATES="cmake cmake3"
>
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> ---
> support/dependencies/check-host-cmake.mk | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/support/dependencies/check-host-cmake.mk b/support/dependencies/check-host-cmake.mk
> index 8002278..42aaee4 100644
> --- a/support/dependencies/check-host-cmake.mk
> +++ b/support/dependencies/check-host-cmake.mk
> @@ -10,9 +10,10 @@
> #
> BR2_CMAKE_VERSION_MIN = 3.1
>
> -BR2_CMAKE ?= cmake
> -ifeq ($(call suitable-host-package,cmake,\
> - $(BR2_CMAKE) $(BR2_CMAKE_VERSION_MIN)),)
> +BR2_CMAKE_CANDIDATES ?= cmake
Do not rename the variable; keep it named BR2_CMAKE.
It was named as such so that one could do:
$ make BR2_CMAKE=/path/to/my/cmake3
and we want to keep it as such, so people can override the cmake they
want to use.
By the way, I hope you knew you could do that, didn't you? ;-)
Regards,
Yann E. MORIN.
> +BR2_CMAKE ?= $(call suitable-host-package,cmake,\
> + $(BR2_CMAKE_CANDIDATES) $(BR2_CMAKE_VERSION_MIN))
> +ifeq ($(BR2_CMAKE),)
> BR2_CMAKE = $(HOST_DIR)/usr/bin/cmake
> BR2_CMAKE_HOST_DEPENDENCY = host-cmake
> endif
> --
> 1.8.3.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-05-05 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 20:30 [Buildroot] [PATCH 0/3] Support a list of "cmake" candidates Carlos Santos
2017-05-05 20:30 ` [Buildroot] [PATCH 1/3] core: allow check-host-cmake.sh to check several candidates Carlos Santos
2017-05-05 21:07 ` Yann E. MORIN
2017-05-05 22:34 ` Carlos Santos
2017-05-05 23:19 ` Carlos Santos
2017-05-06 8:16 ` Yann E. MORIN
2017-05-05 20:30 ` [Buildroot] [PATCH 2/3] core: allow having a list of "cmake" candidates Carlos Santos
2017-05-05 21:09 ` Yann E. MORIN [this message]
2017-05-05 22:43 ` Carlos Santos
2017-05-06 8:17 ` Yann E. MORIN
2017-05-05 20:30 ` [Buildroot] [PATCH 3/3] core: add "cmake3" to the list of cmake candidates Carlos Santos
2017-05-05 21:10 ` Yann E. MORIN
2017-05-06 8:18 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505210928.GB3001@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox