[Buildroot] [PATCH 1/3] core: allow check-host-cmake.sh to check several candidates

[Carlos Santos <casantos@datacom.ind.br>]

> From: "Carlos Santos" <casantos@datacom.ind.br>
> To: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: buildroot at buildroot.org
> Sent: Friday, May 5, 2017 7:34:46 PM
> Subject: Re: [Buildroot] [PATCH 1/3] core: allow check-host-cmake.sh to check several candidates

>> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> To: "Carlos Santos" <casantos@datacom.ind.br>
>> Cc: buildroot at buildroot.org
>> Sent: Friday, May 5, 2017 6:07:03 PM
>> Subject: Re: [Buildroot] [PATCH 1/3] core: allow check-host-cmake.sh to check
>> several candidates
>>> --- a/support/dependencies/check-host-cmake.sh
>>> +++ b/support/dependencies/check-host-cmake.sh
>>> @@ -1,39 +1,41 @@
>>>  #!/bin/sh
>>>  
>>> -candidate="${1}"
>>> -version_min="${2}"
>>> +eval 'version_min="${'${#}'}"'
>> 
>> It took me a moment to understand what this was doing (and I am known
>> for being a shell fanboy!).
>> 
>> Just revert the order options are passed: version first, then
>> candidates. This will allow you to get rid of this weird construct.
>> 
>>    version_min="${1}"
>>    shift # Keep only candidates
> 
> I did it that way because all invocations of the "suitable-host-package"
> macro pass the candidate name as the first argument to the script but I
> must admit that the script lost some readability.

Also, doing it as you suggest requires modifying check-host-cmake.mk
in the same patch to change the argument order, which I'd prefer to
avoid.

-- 
Carlos Santos (Casantos) - DATACOM, P&D
?The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.? ? Christopher Hitchens