[Buildroot] [PATCH v2] package/efl: fix unmet dependencies

[Buildroot] [PATCH v2] package/efl: fix unmet dependencies

[Yann E. MORIN]

EFL's elput selects libinput but forgot to propagate its dependencies.
Which requires they be propagated further to a second sub-option, then
to a third one.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@openwide.fr>

---
Changes v1 -> v2:
  - porpagate dependency to comments as well  (Romain)
  - fix commit log typoes  (Romain, me)
---
 package/efl/Config.in | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/package/efl/Config.in b/package/efl/Config.in
index 371ed3f0d4..7b29e57c0a 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -178,13 +178,15 @@ config BR2_PACKAGE_EFL_WAYLAND
 	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine
 	depends on BR2_PACKAGE_EFL_EEZE # efl drm
 	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
+	depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput
 	select BR2_PACKAGE_EFL_DRM
 	select BR2_PACKAGE_WAYLAND_PROTOCOLS
 
-comment "Wayland support needs udev /dev management (eeze) and OpenGL ES w/ EGL, threads"
+comment "Wayland support needs udev /dev management (eeze), OpenGL ES w/ EGL, threads, locales"
 	depends on BR2_PACKAGE_WAYLAND
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \
-		|| !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE
+		|| !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE \
+		|| !BR2_ENABLE_LOCALE
 
 choice
 	bool "OpenGL support"
@@ -216,6 +218,7 @@ endchoice # OpenGL support
 
 config BR2_PACKAGE_EFL_ELPUT
 	bool "Elput"
+	depends on BR2_ENABLE_LOCALE # libinput
 	depends on BR2_PACKAGE_EFL_EEZE
 	select BR2_PACKAGE_LIBINPUT
 	select BR2_PACKAGE_LIBXKBCOMMON
@@ -226,23 +229,24 @@ config BR2_PACKAGE_EFL_ELPUT
 	  libinput without having to duplicate the code in each
 	  subsystem.
 
-comment "Elput support needs udev /dev management (eeze)"
-	depends on !BR2_PACKAGE_EFL_EEZE
+comment "Elput support needs udev /dev management (eeze), locales"
+	depends on !BR2_PACKAGE_EFL_EEZE || !BR2_ENABLE_LOCALE
 
 config BR2_PACKAGE_EFL_DRM
 	bool "Evas DRM Engine"
 	depends on BR2_PACKAGE_EFL_EEZE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
 	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d
+	depends on BR2_ENABLE_LOCALE # efl-elput <- libinput
 	select BR2_PACKAGE_EFL_ELPUT
 	select BR2_PACKAGE_LIBDRM
 	select BR2_PACKAGE_LIBXKBCOMMON
 	help
 	  This option enable building support for the Evas DRM Engine.
 
-comment "Evas DRM Engine needs udev /dev management (eeze) and mesa3d w/ EGL support, threads"
+comment "Evas DRM Engine needs udev /dev management (eeze), mesa3d w/ EGL support, threads, locales"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \
-		|| !BR2_PACKAGE_EFL_EEZE
+		|| !BR2_PACKAGE_EFL_EEZE || !Br2_EMNABLE_LOCALE
 
 comment "libevas loaders"
 
-- 
2.11.0

[Buildroot] [PATCH v2] package/efl: fix unmet dependencies

[Romain Naour]

Le 08/05/2017 ? 23:11, Yann E. MORIN a ?crit :
> EFL's elput selects libinput but forgot to propagate its dependencies.
> Which requires they be propagated further to a second sub-option, then
> to a third one.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@openwide.fr>
> 
> ---
> Changes v1 -> v2:
>   - porpagate dependency to comments as well  (Romain)
>   - fix commit log typoes  (Romain, me)
> ---
>  package/efl/Config.in | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 371ed3f0d4..7b29e57c0a 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -178,13 +178,15 @@ config BR2_PACKAGE_EFL_WAYLAND
>  	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine
>  	depends on BR2_PACKAGE_EFL_EEZE # efl drm
>  	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
> +	depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput
>  	select BR2_PACKAGE_EFL_DRM
>  	select BR2_PACKAGE_WAYLAND_PROTOCOLS
>  
> -comment "Wayland support needs udev /dev management (eeze) and OpenGL ES w/ EGL, threads"
> +comment "Wayland support needs udev /dev management (eeze), OpenGL ES w/ EGL, threads, locales"
>  	depends on BR2_PACKAGE_WAYLAND
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \
> -		|| !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE
> +		|| !BR2_PACKAGE_EFL_OPENGLES || !BR2_PACKAGE_EFL_EEZE \
> +		|| !BR2_ENABLE_LOCALE
>  
>  choice
>  	bool "OpenGL support"
> @@ -216,6 +218,7 @@ endchoice # OpenGL support
>  
>  config BR2_PACKAGE_EFL_ELPUT
>  	bool "Elput"
> +	depends on BR2_ENABLE_LOCALE # libinput
>  	depends on BR2_PACKAGE_EFL_EEZE
>  	select BR2_PACKAGE_LIBINPUT
>  	select BR2_PACKAGE_LIBXKBCOMMON
> @@ -226,23 +229,24 @@ config BR2_PACKAGE_EFL_ELPUT
>  	  libinput without having to duplicate the code in each
>  	  subsystem.
>  
> -comment "Elput support needs udev /dev management (eeze)"
> -	depends on !BR2_PACKAGE_EFL_EEZE
> +comment "Elput support needs udev /dev management (eeze), locales"
> +	depends on !BR2_PACKAGE_EFL_EEZE || !BR2_ENABLE_LOCALE
>  
>  config BR2_PACKAGE_EFL_DRM
>  	bool "Evas DRM Engine"
>  	depends on BR2_PACKAGE_EFL_EEZE
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
>  	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # require libgbm from mesa3d
> +	depends on BR2_ENABLE_LOCALE # efl-elput <- libinput
>  	select BR2_PACKAGE_EFL_ELPUT
>  	select BR2_PACKAGE_LIBDRM
>  	select BR2_PACKAGE_LIBXKBCOMMON
>  	help
>  	  This option enable building support for the Evas DRM Engine.
>  
> -comment "Evas DRM Engine needs udev /dev management (eeze) and mesa3d w/ EGL support, threads"
> +comment "Evas DRM Engine needs udev /dev management (eeze), mesa3d w/ EGL support, threads, locales"
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_MESA3D_OPENGL_EGL \
> -		|| !BR2_PACKAGE_EFL_EEZE
> +		|| !BR2_PACKAGE_EFL_EEZE || !Br2_EMNABLE_LOCALE

meh s/Br2/BR2/

s/Br2_EMNABLE_LOCALE/BR2_ENABLE_LOCALE/

:)
Romain

>  
>  comment "libevas loaders"
>  
> 

[Buildroot] [PATCH v2] package/efl: fix unmet dependencies

[Yann E. MORIN]

Romain, All,

On 2017-05-08 23:25 +0200, Romain Naour spake thusly:
> Le 08/05/2017 ? 23:11, Yann E. MORIN a ?crit :
[--SNIP--]
> > +		|| !BR2_PACKAGE_EFL_EEZE || !Br2_EMNABLE_LOCALE
> meh s/Br2/BR2/
> s/Br2_EMNABLE_LOCALE/BR2_ENABLE_LOCALE/

Yep, so I'll refrain from hacking anymore before I get some sleep...

Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2] package/efl: fix unmet dependencies

[Thomas Petazzoni]

Hello,

On Mon,  8 May 2017 23:11:49 +0200, Yann E. MORIN wrote:
> EFL's elput selects libinput but forgot to propagate its dependencies.
> Which requires they be propagated further to a second sub-option, then
> to a third one.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Romain Naour <romain.naour@openwide.fr>
> 
> ---
> Changes v1 -> v2:
>   - porpagate dependency to comments as well  (Romain)
>   - fix commit log typoes  (Romain, me)
> ---
>  package/efl/Config.in | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)

Applied to master, after fixing the typo noticed by Romain. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] package/efl: fix unmet dependencies

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > EFL's elput selects libinput but forgot to propagate its dependencies.
 > Which requires they be propagated further to a second sub-option, then
 > to a third one.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Romain Naour <romain.naour@openwide.fr>

 > ---
 > Changes v1 -> v2:
 >   - porpagate dependency to comments as well  (Romain)
 >   - fix commit log typoes  (Romain, me)
 > ---
 >  package/efl/Config.in | 16 ++++++++++------
 >  1 file changed, 10 insertions(+), 6 deletions(-)

 > diff --git a/package/efl/Config.in b/package/efl/Config.in
 > index 371ed3f0d4..7b29e57c0a 100644
 > --- a/package/efl/Config.in
 > +++ b/package/efl/Config.in
 > @@ -178,13 +178,15 @@ config BR2_PACKAGE_EFL_WAYLAND
 >  	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # Evas DRM Engine
 >  	depends on BR2_PACKAGE_EFL_EEZE # efl drm
 >  	depends on BR2_PACKAGE_EFL_OPENGLES # OpenGL ES with EGL support only
 > +	depends on BR2_ENABLE_LOCALE # efl-drm <- efl-elput <- linput

Committed to 2017.02.x after fixing the s/linput/libinput/ typo, thanks.

-- 
Bye, Peter Korsgaard