Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/3] package/ltp-testsuite: add dependency on BR2_TOOLCHAIN_HAS_SYNC_4
Date: Tue,  9 May 2017 22:59:29 +0200	[thread overview]
Message-ID: <20170509205929.8394-3-romain.naour@gmail.com> (raw)
In-Reply-To: <20170509205929.8394-1-romain.naour@gmail.com>

As stated in commit [1], sparc toolchains doesn't have
any of __sync_*() family of functions implementation.

When __sync_add_and_fetch() is missing, ltp fallback to a local
implementation of tst_atomic_add_return() specific for each
supported architecture.
But there is none for sparc.

So add a dependency on BR2_TOOLCHAIN_HAS_SYNC_4 except for
architectures where a specific implementation is provided
in ltp-testsuite.

Fixes:
http://autobuild.buildroot.net/results/d7c/d7c3b145a64ed3916b89ddb4090050f3b9205e37

[1] 6856e417da4f3aa77e2a814db2a89429af072f7d

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
v3: Fix comment dependency
    Rebase after newly introduced BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS (ThomasP)
v2: add a dependency on BR2_TOOLCHAIN_HAS_SYNC_4 except for arc, i386,
    powerpc, powerpc64, powerpc64le and x86_64
---
 package/ltp-testsuite/Config.in | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
index 699a289..e0e7f62 100644
--- a/package/ltp-testsuite/Config.in
+++ b/package/ltp-testsuite/Config.in
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
 	bool
 	# does not build on nios2, cachectl.h issue
-	default y if !BR2_nios2
+	# Needs __sync*() built-ins for 4-byte data, except on a few
+	# architectures for which a specific implementation is provided
+	# in ltp-testsuite
+	default y if !BR2_nios2 || (BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_arc \
+		|| BR2_i386 || BR2_powerpc || BR2_powerpc64 \
+		|| BR2_powerpc64le || BR2_x86_64)
 
 config BR2_PACKAGE_LTP_TESTSUITE
 	bool "ltp-testsuite"
-- 
2.9.3

  parent reply	other threads:[~2017-05-09 20:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 20:59 [Buildroot] [PATCH v3 1/3] package/ltp-testsuite: remove ldd command test with static only build Romain Naour
2017-05-09 20:59 ` [Buildroot] [PATCH v3 2/3] package/ltp-testsuite: introduce BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS Romain Naour
2017-05-10 21:41   ` Thomas Petazzoni
2017-05-11 20:31     ` Romain Naour
2017-05-09 20:59 ` Romain Naour [this message]
2017-05-09 21:21   ` [Buildroot] [PATCH v3 3/3] package/ltp-testsuite: add dependency on BR2_TOOLCHAIN_HAS_SYNC_4 Thomas Petazzoni
2017-05-10 21:36 ` [Buildroot] [PATCH v3 1/3] package/ltp-testsuite: remove ldd command test with static only build Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509205929.8394-3-romain.naour@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox