Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/3] package/ltp-testsuite: add dependency on BR2_TOOLCHAIN_HAS_SYNC_4
Date: Tue, 9 May 2017 23:21:47 +0200	[thread overview]
Message-ID: <20170509232147.19f21c5d@free-electrons.com> (raw)
In-Reply-To: <20170509205929.8394-3-romain.naour@gmail.com>

Hello,

On Tue,  9 May 2017 22:59:29 +0200, Romain Naour wrote:

>  config BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
>  	bool
>  	# does not build on nios2, cachectl.h issue
> -	default y if !BR2_nios2
> +	# Needs __sync*() built-ins for 4-byte data, except on a few
> +	# architectures for which a specific implementation is provided
> +	# in ltp-testsuite
> +	default y if !BR2_nios2 || (BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_arc \
> +		|| BR2_i386 || BR2_powerpc || BR2_powerpc64 \
> +		|| BR2_powerpc64le || BR2_x86_64)

This is very convoluted. What about:

	depends on !BR2_nios2
	default y if BR2_TOOLCHAIN_HAS_SYNC_4
	default y if BR2_arc
	default y if BR2_i386
	default y if BR2_powerpc
	default y if BR2_powepc64
	default y if BR2_powerpc64le
	default y if BR2_x86_64

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-05-09 21:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 20:59 [Buildroot] [PATCH v3 1/3] package/ltp-testsuite: remove ldd command test with static only build Romain Naour
2017-05-09 20:59 ` [Buildroot] [PATCH v3 2/3] package/ltp-testsuite: introduce BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS Romain Naour
2017-05-10 21:41   ` Thomas Petazzoni
2017-05-11 20:31     ` Romain Naour
2017-05-09 20:59 ` [Buildroot] [PATCH v3 3/3] package/ltp-testsuite: add dependency on BR2_TOOLCHAIN_HAS_SYNC_4 Romain Naour
2017-05-09 21:21   ` Thomas Petazzoni [this message]
2017-05-10 21:36 ` [Buildroot] [PATCH v3 1/3] package/ltp-testsuite: remove ldd command test with static only build Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509232147.19f21c5d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox