From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lsscsi: add new package
Date: Fri, 12 May 2017 15:48:41 +0200 [thread overview]
Message-ID: <20170512154841.6843c130@free-electrons.com> (raw)
In-Reply-To: <CAGm1_kutBSs6At8JvZoTsBQbDWQ6iJRSB3z_AHnLXq8+xbVPiA@mail.gmail.com>
Hello,
On Fri, 12 May 2017 14:29:54 +0200, Yegor Yefremov wrote:
> On Fri, May 12, 2017 at 2:17 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > package/Config.in | 1 +
> > package/lsscsi/Config.in | 6 ++++++
> > package/lsscsi/lsscsi.mk | 13 +++++++++++++
>
> You forgot the hash file.
... and the entry to the DEVELOPERS file.
> > diff --git a/package/lsscsi/Config.in b/package/lsscsi/Config.in
> > new file mode 100644
> > index 0000000000..1c856863a4
> > --- /dev/null
> > +++ b/package/lsscsi/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_LSSCSI
> > + bool "lsscsi"
Was this tested with a sufficient number of toolchains, for example
using supports/scripts/test-pkg ? It really builds fine for all
platforms/libcs, without requiring additional options?
> > +LSSCSI_LICENSE = GPLv2
This should be "GPL-2.0" as we use SPDX identifiers since recently in
Buildroot.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-12 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 12:17 [Buildroot] [PATCH] lsscsi: add new package Antony Pavlov
2017-05-12 12:29 ` Yegor Yefremov
2017-05-12 13:48 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512154841.6843c130@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox