[Buildroot] [PATCH] lsscsi: add new package

[Buildroot] [PATCH] lsscsi: add new package

[Antony Pavlov]

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 package/Config.in        |  1 +
 package/lsscsi/Config.in |  6 ++++++
 package/lsscsi/lsscsi.mk | 13 +++++++++++++
 3 files changed, 20 insertions(+)

diff --git a/package/Config.in b/package/Config.in
index d57813c5c7..35e047b475 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -423,6 +423,7 @@ endmenu
 	source "package/lirc-tools/Config.in"
 	source "package/lm-sensors/Config.in"
 	source "package/lshw/Config.in"
+	source "package/lsscsi/Config.in"
 	source "package/lsuio/Config.in"
 	source "package/lvm2/Config.in"
 	source "package/mali-t76x/Config.in"
diff --git a/package/lsscsi/Config.in b/package/lsscsi/Config.in
new file mode 100644
index 0000000000..1c856863a4
--- /dev/null
+++ b/package/lsscsi/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LSSCSI
+	bool "lsscsi"
+	help
+	  lsscsi - list SCSI devices (or hosts) and their attributes
+
+	  http://sg.danny.cz/scsi/lsscsi.html
diff --git a/package/lsscsi/lsscsi.mk b/package/lsscsi/lsscsi.mk
new file mode 100644
index 0000000000..f5370b1843
--- /dev/null
+++ b/package/lsscsi/lsscsi.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# lsscsi
+#
+################################################################################
+
+LSSCSI_VERSION = 0.28
+LSSCSI_SOURCE = lsscsi-$(LSSCSI_VERSION).tgz
+LSSCSI_SITE = http://sg.danny.cz/scsi
+LSSCSI_LICENSE = GPLv2
+LSSCSI_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
2.11.0

[Buildroot] [PATCH] lsscsi: add new package

[Yegor Yefremov]

Hi Antony,

On Fri, May 12, 2017 at 2:17 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  package/Config.in        |  1 +
>  package/lsscsi/Config.in |  6 ++++++
>  package/lsscsi/lsscsi.mk | 13 +++++++++++++

You forgot the hash file.

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor

>  3 files changed, 20 insertions(+)
>
> diff --git a/package/Config.in b/package/Config.in
> index d57813c5c7..35e047b475 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -423,6 +423,7 @@ endmenu
>         source "package/lirc-tools/Config.in"
>         source "package/lm-sensors/Config.in"
>         source "package/lshw/Config.in"
> +       source "package/lsscsi/Config.in"
>         source "package/lsuio/Config.in"
>         source "package/lvm2/Config.in"
>         source "package/mali-t76x/Config.in"
> diff --git a/package/lsscsi/Config.in b/package/lsscsi/Config.in
> new file mode 100644
> index 0000000000..1c856863a4
> --- /dev/null
> +++ b/package/lsscsi/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_LSSCSI
> +       bool "lsscsi"
> +       help
> +         lsscsi - list SCSI devices (or hosts) and their attributes
> +
> +         http://sg.danny.cz/scsi/lsscsi.html
> diff --git a/package/lsscsi/lsscsi.mk b/package/lsscsi/lsscsi.mk
> new file mode 100644
> index 0000000000..f5370b1843
> --- /dev/null
> +++ b/package/lsscsi/lsscsi.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# lsscsi
> +#
> +################################################################################
> +
> +LSSCSI_VERSION = 0.28
> +LSSCSI_SOURCE = lsscsi-$(LSSCSI_VERSION).tgz
> +LSSCSI_SITE = http://sg.danny.cz/scsi
> +LSSCSI_LICENSE = GPLv2
> +LSSCSI_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH] lsscsi: add new package

[Thomas Petazzoni]

Hello,

On Fri, 12 May 2017 14:29:54 +0200, Yegor Yefremov wrote:

> On Fri, May 12, 2017 at 2:17 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> >  package/Config.in        |  1 +
> >  package/lsscsi/Config.in |  6 ++++++
> >  package/lsscsi/lsscsi.mk | 13 +++++++++++++  
> 
> You forgot the hash file.

... and the entry to the DEVELOPERS file.

> > diff --git a/package/lsscsi/Config.in b/package/lsscsi/Config.in
> > new file mode 100644
> > index 0000000000..1c856863a4
> > --- /dev/null
> > +++ b/package/lsscsi/Config.in
> > @@ -0,0 +1,6 @@
> > +config BR2_PACKAGE_LSSCSI
> > +       bool "lsscsi"

Was this tested with a sufficient number of toolchains, for example
using supports/scripts/test-pkg ? It really builds fine for all
platforms/libcs, without requiring additional options?

> > +LSSCSI_LICENSE = GPLv2

This should be "GPL-2.0" as we use SPDX identifiers since recently in
Buildroot.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com