* [Buildroot] [PATCH] package: libcgi: set upstream to https://github.com/rafaelsteil/libcgi
@ 2017-05-12 22:15 Mario J. Rugiero
2017-05-13 12:59 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Mario J. Rugiero @ 2017-05-12 22:15 UTC (permalink / raw)
To: buildroot
Also, bump to version 1.1 and cleanup. The patch is no longer needed.
Tested with:
nitrogen6sx_defconfig
Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
---
package/libcgi/0001-misc-fixes.patch | 122 -----------------------------------
package/libcgi/Config.in | 2 +-
package/libcgi/libcgi.hash | 4 +-
package/libcgi/libcgi.mk | 10 ++-
4 files changed, 7 insertions(+), 131 deletions(-)
delete mode 100644 package/libcgi/0001-misc-fixes.patch
diff --git a/package/libcgi/0001-misc-fixes.patch b/package/libcgi/0001-misc-fixes.patch
deleted file mode 100644
index b57617854..000000000
--- a/package/libcgi/0001-misc-fixes.patch
+++ /dev/null
@@ -1,122 +0,0 @@
-Index: b/src/cgi.c
-===================================================================
---- a/src/cgi.c
-+++ b/src/cgi.c
-@@ -336,7 +336,7 @@
- hextable['b'] = 11;
- hextable['c'] = 12;
- hextable['d'] = 13;
-- hextable['e'] = 13;
-+ hextable['e'] = 14;
- hextable['f'] = 15;
- hextable['A'] = 10;
- hextable['B'] = 11;
-Index: b/src/string.c
-===================================================================
---- a/src/string.c
-+++ b/src/string.c
-@@ -584,7 +584,7 @@
-
- va_start(ptr, s);
-
-- va_copy(bkp, str);
-+ va_copy(bkp, ptr);
- len = strlen(s);
-
- while (*str) {
-Index: b/Makefile.in
-===================================================================
---- a/Makefile.in
-+++ b/Makefile.in
-@@ -5,22 +5,32 @@
- prefix = @prefix@
- exec_prefix = @exec_prefix@
-
--SHAREDOPT = -shared
-+SHAREDOPT = -shared -fPIC -Wl,-soname,libcgi.so.0
- LIBDIR = $(prefix)/lib
--INCDIR = $(prefix)/include
-+INCDIR = $(prefix)/include/libcgi/
- MANDIR = $(prefix)/man/man3
- SHELL = /bin/sh
- EXTRA_LIBS =
-
- INCS = -Isrc
--FLAGS = -Wall -fpic
-+FLAGS = -Wall -D_REENTRANT
-
- OBJS = src/error.o src/cgi.o src/session.o src/base64.o src/md5.o \
- src/string.o src/general.o src/list.o src/cookie.o
-+SHOBJS=$(OBJS:.o=.sh.o)
-
--.c.o: $(CC) $(FLAGS) -c $<
-+ALL_TARGETS = src/libcgi.a
-+ifeq ($(STATIC),)
-+ALL_TARGETS += src/libcgi.so
-+endif
-
--all: $(OBJS) src/libcgi.so
-+%.o: %.c
-+ $(CC) $(FLAGS) -c $*.c -o $@
-+
-+%.sh.o: %.c
-+ $(CC) $(FLAGS) -fPIC -c $*.c -o $@
-+
-+all: $(ALL_TARGETS)
-
- @echo ""
- @echo ""
-@@ -48,14 +58,17 @@
- src/libcgi.a: $(OBJS)
- $(AR) rc src/libcgi.a $(OBJS)
-
--src/libcgi.so: src/libcgi.a
-- $(CC) $(SHAREDOPT) -o src/libcgi.so $(OBJS) $(EXTRA_LIBS)
-+src/libcgi.so: $(SHOBJS)
-+ $(CC) $(SHAREDOPT) -o src/libcgi.so $(SHOBJS) $(EXTRA_LIBS)
-
- install:
-- cp src/libcgi.a $(LIBDIR)
-- cp src/libcgi.so $(LIBDIR)
-- cp src/cgi.h $(INCDIR)
-- cp src/session.h $(INCDIR)
-+ cp src/libcgi.a $(DESTDIR)/$(LIBDIR)
-+ifeq ($(STATIC),)
-+ cp src/libcgi.so $(DESTDIR)/$(LIBDIR)
-+endif
-+ [ -d $(DESTDIR)/$(INCDIR) ] || mkdir -p $(DESTDIR)/$(INCDIR)
-+ cp src/cgi.h $(DESTDIR)/$(INCDIR)
-+ cp src/session.h $(DESTDIR)/$(INCDIR)
-
-
- src/error.o: src/error.c src/error.h
-@@ -69,8 +82,9 @@
- src/list.o: src/list.c
-
- clean:
-- find src/ -name *.*o -exec rm -f {} \;
-+ find src/ -name *.o -exec rm -f {} \;
- find src/ -name *.a -exec rm -f {} \;
-+ find src/ -name *.so -exec rm -f {} \;
-
- uninstall: clean
- rm -f $(LIBDIR)/libcgi.*
-@@ -78,11 +92,11 @@
- rm -f $(INCDIR)/session.h
- rm -f $(MANDIR)/libcgi*
-
--install_man:
-- cp doc/man/man3/libcgi_base64.3 $(MANDIR)
-- cp doc/man/man3/libcgi_cgi.3 $(MANDIR)
-- cp doc/man/man3/libcgi_general.3 $(MANDIR)
-- cp doc/man/man3/libcgi_string.3 $(MANDIR)
-- cp doc/man/man3/libcgi_session.3 $(MANDIR)
-- cp doc/man/man3/libcgi_cookie.3 $(MANDIR)
-+#install_man:
-+# cp doc/man/man3/libcgi_base64.3 $(MANDIR)
-+# cp doc/man/man3/libcgi_cgi.3 $(MANDIR)
-+# cp doc/man/man3/libcgi_general.3 $(MANDIR)
-+# cp doc/man/man3/libcgi_string.3 $(MANDIR)
-+# cp doc/man/man3/libcgi_session.3 $(MANDIR)
-+# cp doc/man/man3/libcgi_cookie.3 $(MANDIR)
-
diff --git a/package/libcgi/Config.in b/package/libcgi/Config.in
index 430039e55..7a60c60d7 100644
--- a/package/libcgi/Config.in
+++ b/package/libcgi/Config.in
@@ -8,4 +8,4 @@ config BR2_PACKAGE_LIBCGI
session and cookie support, GET and POST methods manipulation
etc..., to help you to quickly write powerful CGI programs.
- http://libcgi.sourceforge.net/
+ https://github.com/rafaelsteil/libcgi
diff --git a/package/libcgi/libcgi.hash b/package/libcgi/libcgi.hash
index 6bd7c0c3d..097340811 100644
--- a/package/libcgi/libcgi.hash
+++ b/package/libcgi/libcgi.hash
@@ -1,2 +1,2 @@
-# Locally computed:
-sha256 861df39cc0195d43419c4c3de8dff4f42478db66c9ba0b0c1e994c99400e130c libcgi-1.0.tar.gz
+# Upstream computed
+sha256 128445f2f828e84905d51bd53d11e2e08c489df3a07225ff9f198c1318092fe6 libcgi-1.1.tar.gz
diff --git a/package/libcgi/libcgi.mk b/package/libcgi/libcgi.mk
index de2a1e4be..da6dc0d3e 100644
--- a/package/libcgi/libcgi.mk
+++ b/package/libcgi/libcgi.mk
@@ -4,12 +4,10 @@
#
################################################################################
-LIBCGI_VERSION = 1.0
-LIBCGI_SITE = http://downloads.sourceforge.net/project/libcgi/libcgi/$(LIBCGI_VERSION)
+LIBCGI_VERSION = 1.1
+LIBCGI_SOURCE = libcgi-$(LIBCGI_VERSION).tar.gz
+LIBCGI_SITE = https://github.com/rafaelsteil/libcgi/releases/download/v$(LIBCGI_VERSION)
LIBCGI_INSTALL_STAGING = YES
-# use cross CC/AR rather than host
-LIBCGI_MAKE_ENV = CC="$(TARGET_CC) $(TARGET_CFLAGS)" AR="$(TARGET_AR)" \
- $(if $(BR2_STATIC_LIBS),STATIC=1)
LIBCGI_LICENSE = LGPL-2.1+
-$(eval $(autotools-package))
+$(eval $(cmake-package))
--
2.13.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] package: libcgi: set upstream to https://github.com/rafaelsteil/libcgi
2017-05-12 22:15 [Buildroot] [PATCH] package: libcgi: set upstream to https://github.com/rafaelsteil/libcgi Mario J. Rugiero
@ 2017-05-13 12:59 ` Thomas Petazzoni
2017-05-14 4:24 ` Mario Rugiero
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-05-13 12:59 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 May 2017 19:15:46 -0300, Mario J. Rugiero wrote:
> Also, bump to version 1.1 and cleanup. The patch is no longer needed.
>
> Tested with:
> nitrogen6sx_defconfig
>
> Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
Thanks, but we already have a similar patch submitted, in
https://patchwork.ozlabs.org/patch/757847/.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package: libcgi: set upstream to https://github.com/rafaelsteil/libcgi
2017-05-13 12:59 ` Thomas Petazzoni
@ 2017-05-14 4:24 ` Mario Rugiero
2017-05-14 7:18 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Mario Rugiero @ 2017-05-14 4:24 UTC (permalink / raw)
To: buildroot
That's right, I should've checked.
There's an upstream computed sha256sum though, shouldn't that be in use?
2017-05-13 9:59 GMT-03:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Hello,
>
> On Fri, 12 May 2017 19:15:46 -0300, Mario J. Rugiero wrote:
>> Also, bump to version 1.1 and cleanup. The patch is no longer needed.
>>
>> Tested with:
>> nitrogen6sx_defconfig
>>
>> Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
>
> Thanks, but we already have a similar patch submitted, in
> https://patchwork.ozlabs.org/patch/757847/.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package: libcgi: set upstream to https://github.com/rafaelsteil/libcgi
2017-05-14 4:24 ` Mario Rugiero
@ 2017-05-14 7:18 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-05-14 7:18 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 14 May 2017 01:24:10 -0300, Mario Rugiero wrote:
> That's right, I should've checked.
> There's an upstream computed sha256sum though, shouldn't that be in use?
Yes, if there's one, it's better if it's used. Perhaps something you
could comment on the original patch, and I can fixup when applying.
Thanks for noticing!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-14 7:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-12 22:15 [Buildroot] [PATCH] package: libcgi: set upstream to https://github.com/rafaelsteil/libcgi Mario J. Rugiero
2017-05-13 12:59 ` Thomas Petazzoni
2017-05-14 4:24 ` Mario Rugiero
2017-05-14 7:18 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox