Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package: acpica: Add host buildling support
Date: Mon, 29 May 2017 23:52:08 +0200	[thread overview]
Message-ID: <20170529235208.7e6fef31@free-electrons.com> (raw)
In-Reply-To: <20170524203030.8187-2-alistair.francis@xilinx.com>

Hello,

Commit titles should have prefixes that look like:

	acpica:

or:

	package/acpica:

and not:

	package: acpica:

Yes, that's a silly convention, but conventions are always silly :)

On Wed, 24 May 2017 13:30:29 -0700, Alistair Francis wrote:
> Add support to build the ACPICA package for the host. This is useful for
> the iasl command which is required to build some packaged, including Xen
> tools

This should have reference the autobuilder issue that it helps fixing
(even if it's only part of the fix).

> +define HOST_ACPICA_BUILD_CMDS
> +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		all
> +endef

Weird that you put the host build command before the target build
command, and then the host install command *after* the target install
command. So I've reordered this.

> +
>  define ACPICA_BUILD_CMDS
>  	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
>  		HARDWARE_NAME=$(BR2_ARCH) HOST=_LINUX CC="$(TARGET_CC)" \
> @@ -23,4 +28,11 @@ define ACPICA_INSTALL_TARGET_CMDS
>  		INSTALLFLAGS=-m755 install
>  endef
>  
> +define HOST_ACPICA_INSTALL_CMDS
> +	$(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		DESTDIR="$(HOST_DIR)" \

DESTDIR="$(HOST_DIR)" is wrong, so I've replaced with
PREFIX="$(HOST_DIR)/usr". See
https://stackoverflow.com/questions/11307465/destdir-and-prefix-of-make
for a quick explanation about the difference.

Applied to master with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2017-05-29 21:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 20:30 [Buildroot] [PATCH 0/2] Add host acpica support Alistair Francis
2017-05-24 20:30 ` [Buildroot] [PATCH 1/2] package: acpica: Add host buildling support Alistair Francis
2017-05-24 21:51   ` Erico Nunes
2017-05-29 21:52   ` Thomas Petazzoni [this message]
2017-05-24 20:30 ` [Buildroot] [PATCH 2/2] package: xen: Depend on the host-acpica package Alistair Francis
2017-05-24 21:51   ` Erico Nunes
2017-05-29 21:53   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529235208.7e6fef31@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox