From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package: xen: Depend on the host-acpica package
Date: Mon, 29 May 2017 23:53:21 +0200 [thread overview]
Message-ID: <20170529235321.14dc3fa4@free-electrons.com> (raw)
In-Reply-To: <20170524203030.8187-3-alistair.francis@xilinx.com>
Hello,
Same comment on the commit title: use "package/xen: " as a prefix.
On Wed, 24 May 2017 13:30:30 -0700, Alistair Francis wrote:
> Add a dependency on the host ACPICA package as Xen tools require iasl to
> build.
Lacks a reference to the autobuilder issue being fixed. I know you have
it in the cover letter, but this is not the place where it is useful:
the cover letter contents don't get committed/preserved anywhere. While
the commit log becomes part of the Git history. So we want to have the
autobuilder reference as part of the commit log.
> XEN_LICENSE_FILES = COPYING
> -XEN_DEPENDENCIES = host-python
> +XEN_DEPENDENCIES = host-python host-acpica
Alphabetic ordering not respected.
I've fixed those issues and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-29 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 20:30 [Buildroot] [PATCH 0/2] Add host acpica support Alistair Francis
2017-05-24 20:30 ` [Buildroot] [PATCH 1/2] package: acpica: Add host buildling support Alistair Francis
2017-05-24 21:51 ` Erico Nunes
2017-05-29 21:52 ` Thomas Petazzoni
2017-05-24 20:30 ` [Buildroot] [PATCH 2/2] package: xen: Depend on the host-acpica package Alistair Francis
2017-05-24 21:51 ` Erico Nunes
2017-05-29 21:53 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529235321.14dc3fa4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox