Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7
Date: Tue, 6 Jun 2017 17:32:22 +0200	[thread overview]
Message-ID: <20170606173222.537500c6@free-electrons.com> (raw)
In-Reply-To: <20170606140850.5823-1-joerg.krause@embedded.rocks>

Hello,

On Tue,  6 Jun 2017 16:08:50 +0200, J?rg Krause wrote:

> diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
> index d670f44747..06986abdd2 100644
> --- a/toolchain/toolchain-common.in
> +++ b/toolchain/toolchain-common.in
> @@ -13,10 +13,9 @@ comment "Toolchain Generic Options"
>  # ints before GCC 7
>  config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
>  	bool
> -	default y if BR2_nios2
> -	default y if BR2_ARM_CPU_ARMV4
> -	default y if BR2_ARM_CPU_ARMV5
> -	default y if BR2_sparc_v8
> +	default y if (BR2_nios2 || BR2_ARM_CPU_ARMV4 || \
> +		BR2_ARM_CPU_ARMV5 || BR2_sparc_v8) && \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_7

This feels very complicated. What about just:

	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-06-06 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 14:08 [Buildroot] [PATCH] toolchain/toolchain-common.in: update definition of BR2_TOOLCHAIN_HAS_GCC_BUG_64735 for GCC 7 Jörg Krause
2017-06-06 15:32 ` Thomas Petazzoni [this message]
2017-06-06 18:44   ` Jörg Krause
2017-06-06 19:23     ` Thomas Petazzoni
2017-06-06 19:35       ` Jörg Krause
2017-06-06 19:42         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606173222.537500c6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox