[Buildroot] [PATCH 1/2] package/lcdproc: override freetype-config path

[Buildroot] [PATCH 1/2] package/lcdproc: override freetype-config path

[Romain Naour]

freetype-config from the host system may be used when installed.
Make sure that the one from HOST_DIR is used.

checking if freetype support has been enabled... yes
checking for freetype-config... /usr/bin/freetype-config
checking for FreeType -- version >= 7.0.1... cross compiling; assuming OK... yes

Fixes:
http://autobuild.buildroot.net/results/c7c/c7c52cd56b985fd73434d5997e9a6ab3f7d7e71e

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/lcdproc/lcdproc.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
index c6476eb..5196368 100644
--- a/package/lcdproc/lcdproc.mk
+++ b/package/lcdproc/lcdproc.mk
@@ -18,6 +18,8 @@ endif
 
 LCDPROC_DEPENDENCIES = freetype ncurses zlib
 
+LCDPROC_CONF_ENV += ac_cv_path_FT2_CONFIG=$(STAGING_DIR)/usr/bin/freetype-config
+
 ifeq ($(BR2_PACKAGE_LIBPNG),y)
 LCDPROC_DEPENDENCIES += libpng
 LCDPROC_CONF_OPTS += --enable-libpng
-- 
2.9.4

[Buildroot] [PATCH 2/2] package lcdproc: override libpng-config path

[Romain Naour]

Like for freetype-config, override libpng-config path otherwise
the one from the host system may be used when installed.
Make sure that the one from HOST_DIR is used.

configure:7480: checking for libpng-config
configure:7498: found /usr/bin/libpng-config
configure:7510: result: /usr/bin/libpng-config
configure:7529: checking whether libpng is present and sane
[...]
nios2-linux-gnu-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/libpng12'

Fixes
http://autobuild.buildroot.net/results/b68/b68f54404a7d412d639ebb6d052412eea6ee3bf1/lcdproc-0.5.7/config.log

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/lcdproc/lcdproc.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
index 5196368..e602088 100644
--- a/package/lcdproc/lcdproc.mk
+++ b/package/lcdproc/lcdproc.mk
@@ -22,6 +22,7 @@ LCDPROC_CONF_ENV += ac_cv_path_FT2_CONFIG=$(STAGING_DIR)/usr/bin/freetype-config
 
 ifeq ($(BR2_PACKAGE_LIBPNG),y)
 LCDPROC_DEPENDENCIES += libpng
+LCDPROC_CONF_ENV += ac_cv_path__png_config=$(STAGING_DIR)/usr/bin/libpng-config
 LCDPROC_CONF_OPTS += --enable-libpng
 else
 LCDPROC_CONF_OPTS += --disable-libpng
-- 
2.9.4

[Buildroot] [PATCH 2/2] package lcdproc: override libpng-config path

[Thomas Petazzoni]

Hello,

On Sun, 11 Jun 2017 15:13:17 +0200, Romain Naour wrote:
> Like for freetype-config, override libpng-config path otherwise
> the one from the host system may be used when installed.
> Make sure that the one from HOST_DIR is used.

You wanted to say STAGING_DIR here, right?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] package lcdproc: override libpng-config path

[Romain Naour]

Le 11/06/2017 ? 15:23, Thomas Petazzoni a ?crit :
> Hello,
> 
> On Sun, 11 Jun 2017 15:13:17 +0200, Romain Naour wrote:
>> Like for freetype-config, override libpng-config path otherwise
>> the one from the host system may be used when installed.
>> Make sure that the one from HOST_DIR is used.
> 
> You wanted to say STAGING_DIR here, right?

Humm yes, same for the patch 1/2...

Best regards,
Romain

> 
> Thanks,
> 
> Thomas
> 

[Buildroot] [PATCH 1/2] package/lcdproc: override freetype-config path

[Thomas Petazzoni]

Hello,

On Sun, 11 Jun 2017 15:13:16 +0200, Romain Naour wrote:
> freetype-config from the host system may be used when installed.
> Make sure that the one from HOST_DIR is used.
> 
> checking if freetype support has been enabled... yes
> checking for freetype-config... /usr/bin/freetype-config
> checking for FreeType -- version >= 7.0.1... cross compiling; assuming OK... yes
> 
> Fixes:
> http://autobuild.buildroot.net/results/c7c/c7c52cd56b985fd73434d5997e9a6ab3f7d7e71e
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/lcdproc/lcdproc.mk | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks. However, it's quite surprising to see this
change, only a week after you did commit
ce2e622dfe8a3f36bdf0c25b37a9f6ebbb23b6cc. What happened?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] package lcdproc: override libpng-config path

[Thomas Petazzoni]

Hello,

On Sun, 11 Jun 2017 15:13:17 +0200, Romain Naour wrote:
> Like for freetype-config, override libpng-config path otherwise
> the one from the host system may be used when installed.
> Make sure that the one from HOST_DIR is used.
> 
> configure:7480: checking for libpng-config
> configure:7498: found /usr/bin/libpng-config
> configure:7510: result: /usr/bin/libpng-config
> configure:7529: checking whether libpng is present and sane
> [...]
> nios2-linux-gnu-gcc: ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include/libpng12'
> 
> Fixes
> http://autobuild.buildroot.net/results/b68/b68f54404a7d412d639ebb6d052412eea6ee3bf1/lcdproc-0.5.7/config.log
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/lcdproc/lcdproc.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] package/lcdproc: override freetype-config path

[Romain Naour]

Hi Thomas,

Le 11/06/2017 ? 17:49, Thomas Petazzoni a ?crit :
> Hello,
> 
> On Sun, 11 Jun 2017 15:13:16 +0200, Romain Naour wrote:
>> freetype-config from the host system may be used when installed.
>> Make sure that the one from HOST_DIR is used.
>>
>> checking if freetype support has been enabled... yes
>> checking for freetype-config... /usr/bin/freetype-config
>> checking for FreeType -- version >= 7.0.1... cross compiling; assuming OK... yes
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/c7c/c7c52cd56b985fd73434d5997e9a6ab3f7d7e71e
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>>  package/lcdproc/lcdproc.mk | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Applied to master, thanks. However, it's quite surprising to see this
> change, only a week after you did commit
> ce2e622dfe8a3f36bdf0c25b37a9f6ebbb23b6cc. What happened?

For some reason, freetype-config is miss-detected on some host machine and
/usr/bin/freetype-config is used instead of
${STAGING_DIR}/usr/bin/freetype-config. Weird... I have /usr/bin/freetype-config
installed on my host but even without this patch,
${STAGING_DIR}/usr/bin/freetype-config is used.

The same happen for libpng-config...

So, instead of relying on configure script, override freetype-config and
libpng-config path.

Best regards,
Romain


> 
> Thanks!
> 
> Thomas
>