Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.
Date: Mon, 19 Jun 2017 17:40:32 +0200	[thread overview]
Message-ID: <20170619174032.4f597cb2@windsurf.lan> (raw)
In-Reply-To: <20170619135953.16205-2-thomas.claveirole@green-communications.fr>

Hello,

On Mon, 19 Jun 2017 15:59:53 +0200, Thomas Claveirole wrote:

> +FCGIWRAP_CONF_OPTS += CFLAGS='-Wno-error $(TARGET_CFLAGS)'

Should be:

FCGIWRAP_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-error"

I.e:

 - Use CONF_ENV, not CONF_OPTS, since we pass the original CFLAGS in
   CONV_ENV

 - Use double quotes instead of simple quotes

 - Pass your option *after* TARGET_CFLAGS.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-06-19 15:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 13:25 [Buildroot] [PATCH 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure Thomas Claveirole
2017-06-19 13:34 ` Baruch Siach
2017-06-19 13:59   ` [Buildroot] [PATCH v2 0/1] " Thomas Claveirole
2017-06-19 13:59     ` [Buildroot] [PATCH v2 1/1] " Thomas Claveirole
2017-06-19 15:40       ` Thomas Petazzoni [this message]
2017-06-19 16:26         ` [Buildroot] [PATCH v3 0/1] " Thomas Claveirole
2017-06-19 16:26           ` [Buildroot] [PATCH v3 1/1] " Thomas Claveirole
2017-06-19 19:30             ` Thomas Petazzoni
2017-06-25 22:30             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619174032.4f597cb2@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox