[Buildroot] [PATCH 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Buildroot] [PATCH 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Claveirole]

fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
to build the package.  This is an issue when Buildroot supports a new
compiler version and this version makes some warnings appear.
Luckily, one can provide CFLAGS=-Wno-error to the configure script so
it appends -Wno-error to AM_CFLAGS.

Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
---
 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/fcgiwrap/fcgiwrap.mk b/package/fcgiwrap/fcgiwrap.mk
index dd74c1ef72..c080a1ae49 100644
--- a/package/fcgiwrap/fcgiwrap.mk
+++ b/package/fcgiwrap/fcgiwrap.mk
@@ -10,6 +10,7 @@ FCGIWRAP_DEPENDENCIES = host-pkgconf libfcgi
 FCGIWRAP_LICENSE = MIT
 FCGIWRAP_LICENSE_FILES = COPYING
 FCGIWRAP_AUTORECONF = YES
+FCGIWRAP_CONF_OPTS += CFLAGS=-Wno-error
 
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 FCGIWRAP_DEPENDENCIES += systemd
-- 
2.11.0

[Buildroot] [PATCH 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Baruch Siach]

Hi Thomas,

On Mon, Jun 19, 2017 at 03:25:13PM +0200, Thomas Claveirole wrote:
> fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
> to build the package.  This is an issue when Buildroot supports a new
> compiler version and this version makes some warnings appear.
> Luckily, one can provide CFLAGS=-Wno-error to the configure script so
> it appends -Wno-error to AM_CFLAGS.

Please add a reference to the autobuild failure:

http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

baruch

> Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
> ---
>  package/fcgiwrap/fcgiwrap.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/fcgiwrap/fcgiwrap.mk b/package/fcgiwrap/fcgiwrap.mk
> index dd74c1ef72..c080a1ae49 100644
> --- a/package/fcgiwrap/fcgiwrap.mk
> +++ b/package/fcgiwrap/fcgiwrap.mk
> @@ -10,6 +10,7 @@ FCGIWRAP_DEPENDENCIES = host-pkgconf libfcgi
>  FCGIWRAP_LICENSE = MIT
>  FCGIWRAP_LICENSE_FILES = COPYING
>  FCGIWRAP_AUTORECONF = YES
> +FCGIWRAP_CONF_OPTS += CFLAGS=-Wno-error
>  
>  ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>  FCGIWRAP_DEPENDENCIES += systemd

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH v2 0/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Claveirole]

Hi,

> Please add a reference to the autobuild failure:
>
> http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

Done, thanks.  I also forgot to mention $(TARGET_CFLAGS) when
overriding the CFLAGS for configure, this should be fixed now.

Thomas Claveirole (1):
  fcgiwrap: Disable -Werror in CFLAGS set by configure.

 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)

-- 
2.11.0

[Buildroot] [PATCH v2 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Claveirole]

Thus, fix
http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
to build the package.  This is an issue when Buildroot supports a new
compiler version and this version makes some warnings appear.
Luckily, one can provide CFLAGS=-Wno-error to the configure script so
it appends -Wno-error to AM_CFLAGS.

Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
---
 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/fcgiwrap/fcgiwrap.mk b/package/fcgiwrap/fcgiwrap.mk
index dd74c1ef72..aed68dcedc 100644
--- a/package/fcgiwrap/fcgiwrap.mk
+++ b/package/fcgiwrap/fcgiwrap.mk
@@ -10,6 +10,7 @@ FCGIWRAP_DEPENDENCIES = host-pkgconf libfcgi
 FCGIWRAP_LICENSE = MIT
 FCGIWRAP_LICENSE_FILES = COPYING
 FCGIWRAP_AUTORECONF = YES
+FCGIWRAP_CONF_OPTS += CFLAGS='-Wno-error $(TARGET_CFLAGS)'
 
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 FCGIWRAP_DEPENDENCIES += systemd
-- 
2.11.0

[Buildroot] [PATCH v2 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 15:59:53 +0200, Thomas Claveirole wrote:

> +FCGIWRAP_CONF_OPTS += CFLAGS='-Wno-error $(TARGET_CFLAGS)'

Should be:

FCGIWRAP_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-error"

I.e:

 - Use CONF_ENV, not CONF_OPTS, since we pass the original CFLAGS in
   CONV_ENV

 - Use double quotes instead of simple quotes

 - Pass your option *after* TARGET_CFLAGS.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v3 0/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Claveirole]

> Should be:
>
> FCGIWRAP_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-error"
>
> I.e:
>
>  - Use CONF_ENV, not CONF_OPTS, since we pass the original CFLAGS in
>    CONV_ENV
>
>  - Use double quotes instead of simple quotes
>
>  - Pass your option *after* TARGET_CFLAGS.

Done, thanks.

Thomas Claveirole (1):
  fcgiwrap: Disable -Werror in CFLAGS set by configure.

 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)

-- 
2.11.0

[Buildroot] [PATCH v3 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Claveirole]

Thus, fix
http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
to build the package.  This is an issue when Buildroot supports a new
compiler version and this version makes some warnings appear.
Luckily, one can provide CFLAGS=-Wno-error to the configure script so
it appends -Wno-error to AM_CFLAGS.

Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
---
 package/fcgiwrap/fcgiwrap.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/fcgiwrap/fcgiwrap.mk b/package/fcgiwrap/fcgiwrap.mk
index dd74c1ef72..62c4c1369d 100644
--- a/package/fcgiwrap/fcgiwrap.mk
+++ b/package/fcgiwrap/fcgiwrap.mk
@@ -10,6 +10,7 @@ FCGIWRAP_DEPENDENCIES = host-pkgconf libfcgi
 FCGIWRAP_LICENSE = MIT
 FCGIWRAP_LICENSE_FILES = COPYING
 FCGIWRAP_AUTORECONF = YES
+FCGIWRAP_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -Wno-error"
 
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 FCGIWRAP_DEPENDENCIES += systemd
-- 
2.11.0

[Buildroot] [PATCH v3 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 18:26:05 +0200, Thomas Claveirole wrote:
> Thus, fix
> http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/
> 
> fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
> to build the package.  This is an issue when Buildroot supports a new
> compiler version and this version makes some warnings appear.
> Luckily, one can provide CFLAGS=-Wno-error to the configure script so
> it appends -Wno-error to AM_CFLAGS.
> 
> Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
> ---
>  package/fcgiwrap/fcgiwrap.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v3 1/1] fcgiwrap: Disable -Werror in CFLAGS set by configure.

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Claveirole <thomas.claveirole@green-communications.fr> writes:

 > Thus, fix
 > http://autobuild.buildroot.net/results/8e0/8e04bf5a85ecd7f120bc9dedeedc891def6c46c1/

 > fcgiwrap's configure script appends -Werror to AM_CFLAGS, then use it
 > to build the package.  This is an issue when Buildroot supports a new
 > compiler version and this version makes some warnings appear.
 > Luckily, one can provide CFLAGS=-Wno-error to the configure script so
 > it appends -Wno-error to AM_CFLAGS.

 > Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>

Committed to 2017.02.x and 2017.05.x, thanks.

-- 
Bye, Peter Korsgaard