[Buildroot] [PATCH v1] qt5multimedia: fix plugins videonode egl x11 header related compile failure

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Mon, 26 Jun 2017 23:13:11 +0200, Peter Seiderer wrote:

> +diff --git a/src/plugins/videonode/egl/egl.pro b/src/plugins/videonode/egl/egl.pro
> +index 7151123..08ec149 100644
> +--- a/src/plugins/videonode/egl/egl.pro
> ++++ b/src/plugins/videonode/egl/egl.pro
> +@@ -3,6 +3,9 @@ TARGET = eglvideonode
> + QT += multimedia-private qtmultimediaquicktools-private
> + CONFIG += egl
> + 
> ++# Avoid X11 header collision, use generic EGL native types
> ++DEFINES += MESA_EGL_NO_X11_HEADERS
> ++

I am not really convinced by this patch. Indeed, I believe it should be
the OpenGL providers that define this constant when needed. If you look
at the config that generated the build failure you're trying to fix
(http://autobuild.buildroot.net/results/364/364a76bbf90251f9cae2abd3ef2e382758eae538),
you'll see that the OpenGL provider used is mali-t76x. However,
package/mali-t76x/glesv2.pc contains:

Cflags: -I${includedir} -DMESA_EGL_NO_X11_HEADERS

So, I would expect that Qt5 should not need to redefine it again.
Obviously, what worries me is that fixing Qt5 will fix just Qt5, and
not any other package using the same OpenGL provider.

What do you think?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com