From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5multimedia: fix plugins videonode egl x11 header related compile failure
Date: Sun, 2 Jul 2017 23:14:49 +0200 [thread overview]
Message-ID: <20170702231449.4a4d1832@windsurf> (raw)
In-Reply-To: <20170702210127.7090df5b@gmx.net>
Hello,
On Sun, 2 Jul 2017 21:01:27 +0200, Peter Seiderer wrote:
> Same fixing pattern as for qt5base (and for qtbase accepted upstream, see e.g. [1]),
Well, [1] is about adding QT_EGL_NO_X11, which is a QT definition. It
is very different from MESA_EGL_NO_X11_HEADERS, which is an
OpenGL-level definition.
> but in general your are right, honor the given provider provided flags would be
> the better solution...maybe something as suggested on the yocto meta-freescale
> mailing list will work, see [2], [3]: 'egl.prf: Fix build error when egl headers
> need platform definition'?
I'm not sure I fully understand those patches, but apparently they use
more pkg-config flags from OpenGL, which is exactly the approach I
suggest to investigate indeed.
BTW, the same thing should be done for Qt instead of
package/qt/0012-OpenGL-EGL-Avoid-X11-header-collision.patch.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-02 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 21:13 [Buildroot] [PATCH v1] qt5multimedia: fix plugins videonode egl x11 header related compile failure Peter Seiderer
2017-07-01 22:33 ` Thomas Petazzoni
2017-07-02 19:01 ` Peter Seiderer
2017-07-02 21:14 ` Thomas Petazzoni [this message]
2017-07-03 18:46 ` Peter Seiderer
2017-07-03 19:02 ` Thomas Petazzoni
2017-07-05 19:53 ` Peter Seiderer
2017-07-05 20:03 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170702231449.4a4d1832@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox