* [Buildroot] [PATCH] .gitlab-ci.yml: fix it again
@ 2017-07-01 18:22 Arnout Vandecappelle
2017-07-01 22:34 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2017-07-01 18:22 UTC (permalink / raw)
To: buildroot
It seems the ! is removed by the yaml parser, so it needs to be quoted.
While we're at it, add some explanatory comment.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
.gitlab-ci.yml | 5 ++++-
.gitlab-ci.yml.in | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 6bd983750d..eda8af4997 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -35,8 +35,11 @@ check-gitlab-ci.yml:
- diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
check-DEVELOPERS:
+ # get-developers should print just "No action specified"; if it prints
+ # anything else, it's a parse error.
+ # The initial ! is removed by YAML so we need to quote it.
script:
- - ! utils/get-developers | grep -v 'No action specified'
+ - "! utils/get-developers | grep -v 'No action specified'"
.defconfig: &defconfig
# Running the defconfigs for every push is too much, so limit to
diff --git a/.gitlab-ci.yml.in b/.gitlab-ci.yml.in
index 0855bffb79..24a1888c1e 100644
--- a/.gitlab-ci.yml.in
+++ b/.gitlab-ci.yml.in
@@ -35,8 +35,11 @@ check-gitlab-ci.yml:
- diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
check-DEVELOPERS:
+ # get-developers should print just "No action specified"; if it prints
+ # anything else, it's a parse error.
+ # The initial ! is removed by YAML so we need to quote it.
script:
- - ! utils/get-developers | grep -v 'No action specified'
+ - "! utils/get-developers | grep -v 'No action specified'"
.defconfig: &defconfig
# Running the defconfigs for every push is too much, so limit to
--
2.13.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] .gitlab-ci.yml: fix it again
2017-07-01 18:22 [Buildroot] [PATCH] .gitlab-ci.yml: fix it again Arnout Vandecappelle
@ 2017-07-01 22:34 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-07-01 22:34 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 1 Jul 2017 20:22:27 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> It seems the ! is removed by the yaml parser, so it needs to be quoted.
> While we're at it, add some explanatory comment.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> .gitlab-ci.yml | 5 ++++-
> .gitlab-ci.yml.in | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-01 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-01 18:22 [Buildroot] [PATCH] .gitlab-ci.yml: fix it again Arnout Vandecappelle
2017-07-01 22:34 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox