* [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare
@ 2017-07-01 18:00 Thomas De Schampheleire
2017-07-01 18:21 ` Yann E. MORIN
2017-07-01 22:35 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2017-07-01 18:00 UTC (permalink / raw)
To: buildroot
A few typos sneaked into the new utils readme...
Additionally, I formulated the list of use cases a bit differently.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
utils/readme.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utils/readme.txt b/utils/readme.txt
index a90805fb0..fd20e8ee6 100644
--- a/utils/readme.txt
+++ b/utils/readme.txt
@@ -28,10 +28,10 @@ scanpypi
a script to create a Buildroot package by scanning a PyPI package
description.
-size-stat-compare
- a script to compare the rootfs size between two differnt Buildroot
+size-stats-compare
+ a script to compare the rootfs size between two different Buildroot
configurations. This can be used to identify the size impact of
- a specific option, or of a set of specific options, or an update
+ a specific option, of a set of specific options, or of an update
to a newer Buildroot version...
test-pkg
--
2.13.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare
2017-07-01 18:00 [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare Thomas De Schampheleire
@ 2017-07-01 18:21 ` Yann E. MORIN
2017-07-02 12:26 ` Thomas De Schampheleire
2017-07-01 22:35 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2017-07-01 18:21 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2017-07-01 20:00 +0200, Thomas De Schampheleire spake thusly:
> A few typos sneaked into the new utils readme...
Yup, sorry...
> Additionally, I formulated the list of use cases a bit differently.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
> utils/readme.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/utils/readme.txt b/utils/readme.txt
> index a90805fb0..fd20e8ee6 100644
> --- a/utils/readme.txt
> +++ b/utils/readme.txt
> @@ -28,10 +28,10 @@ scanpypi
> a script to create a Buildroot package by scanning a PyPI package
> description.
>
> -size-stat-compare
> - a script to compare the rootfs size between two differnt Buildroot
> +size-stats-compare
> + a script to compare the rootfs size between two different Buildroot
> configurations. This can be used to identify the size impact of
> - a specific option, or of a set of specific options, or an update
> + a specific option, of a set of specific options, or of an update
I still believe the current situation is prefereable, because it is :
the impact of
- a specific option, or of a set of options,
or
- a new buildroot version
(use of the Oxford comma is very important, here! ;-] )
But yours is not completely incorrect either. ;-)
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> to a newer Buildroot version...
>
> test-pkg
> --
> 2.13.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare
2017-07-01 18:00 [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare Thomas De Schampheleire
2017-07-01 18:21 ` Yann E. MORIN
@ 2017-07-01 22:35 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-07-01 22:35 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 1 Jul 2017 20:00:27 +0200, Thomas De Schampheleire wrote:
> A few typos sneaked into the new utils readme...
>
> Additionally, I formulated the list of use cases a bit differently.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
> utils/readme.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare
2017-07-01 18:21 ` Yann E. MORIN
@ 2017-07-02 12:26 ` Thomas De Schampheleire
0 siblings, 0 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2017-07-02 12:26 UTC (permalink / raw)
To: buildroot
On Sat, Jul 01, 2017 at 08:21:29PM +0200, Yann E. MORIN wrote:
> Thomas, All,
>
> On 2017-07-01 20:00 +0200, Thomas De Schampheleire spake thusly:
> > A few typos sneaked into the new utils readme...
>
> Yup, sorry...
>
> > Additionally, I formulated the list of use cases a bit differently.
> >
> > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> > ---
> > utils/readme.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/utils/readme.txt b/utils/readme.txt
> > index a90805fb0..fd20e8ee6 100644
> > --- a/utils/readme.txt
> > +++ b/utils/readme.txt
> > @@ -28,10 +28,10 @@ scanpypi
> > a script to create a Buildroot package by scanning a PyPI package
> > description.
> >
> > -size-stat-compare
> > - a script to compare the rootfs size between two differnt Buildroot
> > +size-stats-compare
> > + a script to compare the rootfs size between two different Buildroot
> > configurations. This can be used to identify the size impact of
> > - a specific option, or of a set of specific options, or an update
> > + a specific option, of a set of specific options, or of an update
>
> I still believe the current situation is prefereable, because it is :
>
> the impact of
> - a specific option, or of a set of options,
> or
> - a new buildroot version
>
> (use of the Oxford comma is very important, here! ;-] )
Just to make sure we settle this ;-)
The way I see it, the expanded version would be:
... the impact of a specific option, the impact of a set of options, or the
impact of a new buildroot version.
which I would shorten to either of:
... the impact of a specific option, a set of options, or a new buildroot
version.
... the impact of a specific option or set of options, or of a new buildroot
version.
and perhaps other variants, but I feel that _if_ you repeat 'of' in the 'of a
set of options' part, then you must also repeat it in the 'new buildroot
version' part.
Anyway, who reads these readme's anyway? ;-)
/Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-02 12:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-01 18:00 [Buildroot] [PATCH 1/1] utils/readme.txt: fix typos for size-stats-compare Thomas De Schampheleire
2017-07-01 18:21 ` Yann E. MORIN
2017-07-02 12:26 ` Thomas De Schampheleire
2017-07-01 22:35 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox