Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 01/11] package/mke2img: specifying zero inodes means auto
Date: Tue,  4 Jul 2017 00:50:56 +0200	[thread overview]
Message-ID: <20170703225106.1492-2-s.martin49@gmail.com> (raw)
In-Reply-To: <20170703225106.1492-1-s.martin49@gmail.com>

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Currently, leaving the number of inodes to be autocalculated requires
the user to not specify the -i option at all.

Also accept zero as meaning auto; this will help simplify the ext2.mk
code a little bit.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Samuel Martin <s.martin49@gmail.com>

---
changes v2->v3:
- reintroduce this change from Yann' series
---
 package/mke2img/mke2img | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mke2img/mke2img b/package/mke2img/mke2img
index 758b6dee68..266df483aa 100755
--- a/package/mke2img/mke2img
+++ b/package/mke2img/mke2img
@@ -59,7 +59,7 @@ main() {
     esac
 
     # calculate needed inodes
-    if [ -z "${nb_inodes}" ]; then
+    if [ ${nb_inodes:-0} -eq 0 ]; then
         nb_inodes=$(find "${root_dir}" | wc -l)
         nb_inodes=$((nb_inodes+400))
     fi
-- 
2.13.2

  reply	other threads:[~2017-07-03 22:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 22:50 [Buildroot] [PATCH v3 00/11] fs/ext2: cleanup and improvement Samuel Martin
2017-07-03 22:50 ` Samuel Martin [this message]
2017-07-04  6:48   ` [Buildroot] [PATCH v3 01/11] package/mke2img: specifying zero inodes means auto Thomas Petazzoni
2017-07-03 22:50 ` [Buildroot] [PATCH v3 02/11] fs/ext2: always pass the number of inodes Samuel Martin
2017-07-04  6:48   ` Thomas Petazzoni
2017-07-03 22:50 ` [Buildroot] [PATCH v3 03/11] fs/ext2: always pass the label option Samuel Martin
2017-07-04  6:48   ` Thomas Petazzoni
2017-07-03 22:50 ` [Buildroot] [PATCH v3 04/11] fs/ext2: allow reserving zero block for root Samuel Martin
2017-07-04  6:49   ` Thomas Petazzoni
2017-07-03 22:51 ` [Buildroot] [PATCH v3 05/11] fs/ext2: simplify code Samuel Martin
2017-07-04  6:51   ` Thomas Petazzoni
2017-07-03 22:51 ` [Buildroot] [PATCH v3 06/11] package/mke2img: add option to specify block size Samuel Martin
2017-07-04  6:51   ` Thomas Petazzoni
2017-07-03 22:51 ` [Buildroot] [PATCH v3 07/11] fs/ext2: " Samuel Martin
2017-07-04 10:15   ` Arnout Vandecappelle
2017-07-04 11:32   ` Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 08/11] fs/ext2: deprecate BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES option Samuel Martin
2017-07-04 10:35   ` Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 09/11] fs/ext2: use mkfs to generate rootfs image Samuel Martin
2017-07-04  9:37   ` Samuel Martin
2017-07-04 11:36   ` Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 10/11] fs/ext2: Add BR2_TARGET_ROOTFS_EXT2_FEATURES option Samuel Martin
2017-07-04 11:38   ` Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 11/11] package/mke2img: remove package Samuel Martin
2017-07-04 11:40   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703225106.1492-2-s.martin49@gmail.com \
    --to=s.martin49@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox