Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Martin <s.martin49@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 08/11] fs/ext2: deprecate BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES option
Date: Tue,  4 Jul 2017 00:51:03 +0200	[thread overview]
Message-ID: <20170703225106.1492-9-s.martin49@gmail.com> (raw)
In-Reply-To: <20170703225106.1492-1-s.martin49@gmail.com>

Soon, the ext{2,3,4} rootfs image will no longer be generated with
genext2fs, but using mke2fs instead which has no support for the extra
inode number option.

So, deprecate the BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES option and
recommend, in lieu, to set the total inode number, taking account of
the extra ones if needed.

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Cc: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>

---
changes v2->v3:
- new patch (Yann)
---
 Config.in.legacy  | 11 +++++++++++
 fs/ext2/Config.in |  8 --------
 fs/ext2/ext2.mk   |  1 -
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/Config.in.legacy b/Config.in.legacy
index 453c5eb8b8..5efe0d1ba0 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -145,6 +145,17 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2017.08"
 
+config BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES
+	int "extra inodes has been removed" if BR2_TARGET_ROOTFS_EXT2_INODES = 0
+	default 0
+	help
+	  Buildroot now uses mkfs.ext2/3/4 to generate ext2/3/4 images. So
+	  let mkfs automatically selects the number of inodes needed. Set
+	  this option to 0.
+	  Note that, the number of inodes can still be set and passed to
+	  mkfs; so if extra inodes are needed, prefer setting
+	  BR2_TARGET_ROOTFS_EXT2_INODES taking account of them.
+
 config BR2_STRIP_none
 	bool "Strip command 'none' has been removed"
 	select BR2_LEGACY
diff --git a/fs/ext2/Config.in b/fs/ext2/Config.in
index 627294e17f..0071ba2bec 100644
--- a/fs/ext2/Config.in
+++ b/fs/ext2/Config.in
@@ -79,14 +79,6 @@ config BR2_TARGET_ROOTFS_EXT2_INODES
 	int "exact number of inodes (leave at 0 for auto calculation)"
 	default 0
 
-config BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES
-	int "extra inodes" if BR2_TARGET_ROOTFS_EXT2_INODES = 0
-	default 0
-	help
-	  Enter here the number of extra free inodes you want on
-	  your filesystem. By default, Buildroot will not leave
-	  many free inodes.
-
 config BR2_TARGET_ROOTFS_EXT2_RESBLKS
 	int "reserved blocks percentage"
 	default 5
diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
index ec49caa3a5..24643afeb9 100644
--- a/fs/ext2/ext2.mk
+++ b/fs/ext2/ext2.mk
@@ -15,7 +15,6 @@ EXT2_OPTS = \
 	-B $(BR2_TARGET_ROOTFS_EXT2_BLOCK_SIZE) \
 	-b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS) \
 	-i $(BR2_TARGET_ROOTFS_EXT2_INODES) \
-	-I $(BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES) \
 	-r $(BR2_TARGET_ROOTFS_EXT2_RESBLKS) \
 	-l "$(EXT2_LABEL)"
 
-- 
2.13.2

  parent reply	other threads:[~2017-07-03 22:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 22:50 [Buildroot] [PATCH v3 00/11] fs/ext2: cleanup and improvement Samuel Martin
2017-07-03 22:50 ` [Buildroot] [PATCH v3 01/11] package/mke2img: specifying zero inodes means auto Samuel Martin
2017-07-04  6:48   ` Thomas Petazzoni
2017-07-03 22:50 ` [Buildroot] [PATCH v3 02/11] fs/ext2: always pass the number of inodes Samuel Martin
2017-07-04  6:48   ` Thomas Petazzoni
2017-07-03 22:50 ` [Buildroot] [PATCH v3 03/11] fs/ext2: always pass the label option Samuel Martin
2017-07-04  6:48   ` Thomas Petazzoni
2017-07-03 22:50 ` [Buildroot] [PATCH v3 04/11] fs/ext2: allow reserving zero block for root Samuel Martin
2017-07-04  6:49   ` Thomas Petazzoni
2017-07-03 22:51 ` [Buildroot] [PATCH v3 05/11] fs/ext2: simplify code Samuel Martin
2017-07-04  6:51   ` Thomas Petazzoni
2017-07-03 22:51 ` [Buildroot] [PATCH v3 06/11] package/mke2img: add option to specify block size Samuel Martin
2017-07-04  6:51   ` Thomas Petazzoni
2017-07-03 22:51 ` [Buildroot] [PATCH v3 07/11] fs/ext2: " Samuel Martin
2017-07-04 10:15   ` Arnout Vandecappelle
2017-07-04 11:32   ` Arnout Vandecappelle
2017-07-03 22:51 ` Samuel Martin [this message]
2017-07-04 10:35   ` [Buildroot] [PATCH v3 08/11] fs/ext2: deprecate BR2_TARGET_ROOTFS_EXT2_EXTRA_INODES option Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 09/11] fs/ext2: use mkfs to generate rootfs image Samuel Martin
2017-07-04  9:37   ` Samuel Martin
2017-07-04 11:36   ` Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 10/11] fs/ext2: Add BR2_TARGET_ROOTFS_EXT2_FEATURES option Samuel Martin
2017-07-04 11:38   ` Arnout Vandecappelle
2017-07-03 22:51 ` [Buildroot] [PATCH v3 11/11] package/mke2img: remove package Samuel Martin
2017-07-04 11:40   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703225106.1492-9-s.martin49@gmail.com \
    --to=s.martin49@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox