Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR
@ 2017-07-04  9:40 Maxime Hadjinlian
  2017-07-04  9:40 ` [Buildroot] [PATCH 2/3] kodi: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2017-07-04  9:40 UTC (permalink / raw)
  To: buildroot

And at the same time don't encourage use of BR2_DL_DIR

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 docs/manual/adding-packages-generic.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
index 71e27b672..12cf1605d 100644
--- a/docs/manual/adding-packages-generic.txt
+++ b/docs/manual/adding-packages-generic.txt
@@ -263,7 +263,7 @@ information is (assuming the package name is +libfoo+) :
   the file using this URL. Otherwise, Buildroot will assume the file
   to be downloaded is located at +LIBFOO_SITE+. Buildroot will not do
   anything with those additional files, except download them: it will
-  be up to the package recipe to use them from +$(BR2_DL_DIR)+.
+  be up to the package recipe to use them from +$(DL_DIR)+.
 
 * +LIBFOO_SITE_METHOD+ determines the method used to fetch or copy the
   package source code. In many cases, Buildroot guesses the method
@@ -537,6 +537,9 @@ In the action definitions, you can use the following variables:
 * +$(@D)+, which contains the directory in which the package source
   code has been uncompressed.
 
+* +$(DL_DIR)+ contains the path to the directory where all the downloads made
+  by Buildroot are stored.
+
 * +$(TARGET_CC)+, +$(TARGET_LD)+, etc. to get the target
   cross-compilation utilities
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/3] kodi: s/BR2_DL_DIR/DL_DIR/
  2017-07-04  9:40 [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Maxime Hadjinlian
@ 2017-07-04  9:40 ` Maxime Hadjinlian
  2017-07-04  9:40 ` [Buildroot] [PATCH 3/3] spidev-test: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
  2017-07-04 15:20 ` [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2017-07-04  9:40 UTC (permalink / raw)
  To: buildroot

BR2_DL_DIR is not to be used by the package's Makefile.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/kodi/kodi.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index 2636a0b96..7a031b748 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -66,9 +66,9 @@ KODI_CONF_OPTS += \
 	-DNATIVEPREFIX=$(HOST_DIR)/usr \
 	-DDEPENDS_PATH=$(@D) \
 	-DWITH_TEXTUREPACKER=$(HOST_DIR)/usr/bin/TexturePacker \
-	-DLIBDVDCSS_URL=$(BR2_DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \
-	-DLIBDVDNAV_URL=$(BR2_DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \
-	-DLIBDVDREAD_URL=$(BR2_DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz
+	-DLIBDVDCSS_URL=$(DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \
+	-DLIBDVDNAV_URL=$(DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \
+	-DLIBDVDREAD_URL=$(DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz
 
 ifeq ($(BR2_arm),y)
 KODI_CONF_OPTS += -DWITH_ARCH=arm -DWITH_CPU=arm
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 3/3] spidev-test: s/BR2_DL_DIR/DL_DIR/
  2017-07-04  9:40 [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Maxime Hadjinlian
  2017-07-04  9:40 ` [Buildroot] [PATCH 2/3] kodi: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
@ 2017-07-04  9:40 ` Maxime Hadjinlian
  2017-07-04 15:20 ` [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2017-07-04  9:40 UTC (permalink / raw)
  To: buildroot

BR2_DL_DIR is not to be used by the package's Makefile.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/spidev_test/spidev_test.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/spidev_test/spidev_test.mk b/package/spidev_test/spidev_test.mk
index 1f34c6afd..1d657803b 100644
--- a/package/spidev_test/spidev_test.mk
+++ b/package/spidev_test/spidev_test.mk
@@ -32,7 +32,7 @@ endef
 SPIDEV_TEST_POST_PATCH_HOOKS += SPIDEV_ADD_LINUX_IOCTL
 
 define SPIDEV_TEST_EXTRACT_CMDS
-	cp $(BR2_DL_DIR)/$(SPIDEV_TEST_SOURCE) $(@D)/spidev_test.c
+	cp $(DL_DIR)/$(SPIDEV_TEST_SOURCE) $(@D)/spidev_test.c
 endef
 
 define SPIDEV_TEST_BUILD_CMDS
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR
  2017-07-04  9:40 [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Maxime Hadjinlian
  2017-07-04  9:40 ` [Buildroot] [PATCH 2/3] kodi: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
  2017-07-04  9:40 ` [Buildroot] [PATCH 3/3] spidev-test: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
@ 2017-07-04 15:20 ` Thomas Petazzoni
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-07-04 15:20 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue,  4 Jul 2017 11:40:38 +0200, Maxime Hadjinlian wrote:
> And at the same time don't encourage use of BR2_DL_DIR
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
>  docs/manual/adding-packages-generic.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

All three patches applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-07-04 15:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-04  9:40 [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Maxime Hadjinlian
2017-07-04  9:40 ` [Buildroot] [PATCH 2/3] kodi: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
2017-07-04  9:40 ` [Buildroot] [PATCH 3/3] spidev-test: s/BR2_DL_DIR/DL_DIR/ Maxime Hadjinlian
2017-07-04 15:20 ` [Buildroot] [PATCH 1/3] manual: add documentation about DL_DIR Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox