[Buildroot] [PATCH 1/2] toolchain: CodeSourcery AMD64 affected by PR19615

[Buildroot] [PATCH 1/2] toolchain: CodeSourcery AMD64 affected by PR19615

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
 toolchain/toolchain-common.in                                        | 5 +++++
 .../toolchain-external-codesourcery-amd64/Config.in                  | 1 +
 2 files changed, 6 insertions(+)

diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index ed993dd..74e0e06 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -7,6 +7,11 @@ source "package/gdb/Config.in.host"
 
 comment "Toolchain Generic Options"
 
+# https://sourceware.org/bugzilla/show_bug.cgi?id=19615
+# Affect toolchains built with binutils 2.26 (fixed in binutils 2.26.1).
+config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615
+	bool
+
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735
 # exception_ptr, nested_exception, and future from libstdc++ are not
 # available for architectures not supporting always lock-free atomic
diff --git a/toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Config.in b/toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Config.in
index 32d79eb..101e227 100644
--- a/toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Config.in
+++ b/toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Config.in
@@ -11,6 +11,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_AMD64
 	select BR2_HOSTARCH_NEEDS_IA32_LIBS
 	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_7
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_6
+	select BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615 # based-on binutils-2.26
 	help
 	  Sourcery CodeBench toolchain for the amd64 (x86_64)
 	  architectures, from Mentor Graphics. It uses gcc 6.2,
-- 
2.9.4

[Buildroot] [PATCH 2/2] boot/syslinux: disable syslinux legacy-BIOS for toolchains affected by binutils bug 19615

[Romain Naour]

Since [1] syslinux is build with the target toolchain in order to
properly build with gnu-efi package.
But toolchains built with binutils 2.26 break the syslinux legacy-BIOS
build as reported [2].

Thanks to Beno?t Allard for the investigation and the link to the
binutils bug [3].

[1] 6e432d5ecb46959f3c27dbbca48e41512bb40a70
[2] http://lists.busybox.net/pipermail/buildroot/2017-July/196253.html
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=19615

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: Beno?t Allard <benoit.allard@greenbone.net>
---
 boot/syslinux/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/syslinux/Config.in b/boot/syslinux/Config.in
index 299a559..da03549 100644
--- a/boot/syslinux/Config.in
+++ b/boot/syslinux/Config.in
@@ -35,6 +35,7 @@ config BR2_TARGET_SYSLINUX_PXELINUX
 
 config BR2_TARGET_SYSLINUX_MBR
 	bool "install mbr"
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615
 	select BR2_TARGET_SYSLINUX_LEGACY_BIOS
 	help
 	  Install the legacy-BIOS 'mbr' image, to boot off a
-- 
2.9.4

[Buildroot] [PATCH 2/2] boot/syslinux: disable syslinux legacy-BIOS for toolchains affected by binutils bug 19615

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > Since [1] syslinux is build with the target toolchain in order to
 > properly build with gnu-efi package.
 > But toolchains built with binutils 2.26 break the syslinux legacy-BIOS
 > build as reported [2].

 > Thanks to Beno?t Allard for the investigation and the link to the
 > binutils bug [3].

 > [1] 6e432d5ecb46959f3c27dbbca48e41512bb40a70
 > [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196253.html
 > [3] https://sourceware.org/bugzilla/show_bug.cgi?id=19615

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>
 > Cc: Beno?t Allard <benoit.allard@greenbone.net>

Committed to 2017.05.x, thanks.

I take it that our internal 2.26.1 binutils isn't affected by this?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] toolchain: CodeSourcery AMD64 affected by PR19615

[Thomas Petazzoni]

Hello,

On Tue,  4 Jul 2017 14:01:09 +0200, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
>  toolchain/toolchain-common.in                                        | 5 +++++
>  .../toolchain-external-codesourcery-amd64/Config.in                  | 1 +
>  2 files changed, 6 insertions(+)

Both applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] toolchain: CodeSourcery AMD64 affected by PR19615

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>

Committed to 2017.05.x, thanks.

-- 
Bye, Peter Korsgaard