Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] toolchain-external: drop reference to non-existing variable
@ 2017-07-06  4:28 Baruch Siach
  2017-07-06  9:46 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2017-07-06  4:28 UTC (permalink / raw)
  To: buildroot

Commit 32bec8ee2fb0 (toolchain-external: copy ld*.so* for all C libraries)
removed the definition of TOOLCHAIN_EXTERNAL_MUSL_LD_LINK. Remove also the
reference to it.

Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
This addresses my comment on the patch.
http://lists.busybox.net/pipermail/buildroot/2017-July/195993.html
---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
index 33449d37a5ec..1c5a5790f0e1 100644
--- a/toolchain/toolchain-external/pkg-toolchain-external.mk
+++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
@@ -561,10 +561,6 @@ define $(2)_INSTALL_STAGING_CMDS
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_GDBINIT)
 endef
 
-ifeq ($$(BR2_TOOLCHAIN_EXTERNAL_MUSL),y)
-$(2)_POST_INSTALL_STAGING_HOOKS += TOOLCHAIN_EXTERNAL_MUSL_LD_LINK
-endif
-
 # Even though we're installing things in both the staging, the host
 # and the target directory, we do everything within the
 # install-staging step, arbitrarily.
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] toolchain-external: drop reference to non-existing variable
  2017-07-06  4:28 [Buildroot] [PATCH] toolchain-external: drop reference to non-existing variable Baruch Siach
@ 2017-07-06  9:46 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-07-06  9:46 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu,  6 Jul 2017 07:28:00 +0300, Baruch Siach wrote:
> Commit 32bec8ee2fb0 (toolchain-external: copy ld*.so* for all C libraries)
> removed the definition of TOOLCHAIN_EXTERNAL_MUSL_LD_LINK. Remove also the
> reference to it.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> This addresses my comment on the patch.
> http://lists.busybox.net/pipermail/buildroot/2017-July/195993.html

Sorry, I saw your comment, and it was definitely right. But we have
been reviewing/merging so many patches, and discussing so many topics
that I forgot to take into account your comment.

I've applied your patch now. Thanks for reviewing and fixing this
mistake.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-06  9:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-06  4:28 [Buildroot] [PATCH] toolchain-external: drop reference to non-existing variable Baruch Siach
2017-07-06  9:46 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox