From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Patch not being applied to out of tree package
Date: Fri, 7 Jul 2017 15:52:57 +0200 [thread overview]
Message-ID: <20170707155257.78b51950@windsurf> (raw)
In-Reply-To: <1499430383935-170337.post@n4.nabble.com>
Hello,
On Fri, 7 Jul 2017 05:26:23 -0700 (PDT), ngu wrote:
> My goal is to integrate a driver to buildroot.
> From what I understand, the best way to do so is to create a package, this
> is what I did. The package is out of tree which is not a problem a I
> correctly set the BR2_EXTERNAL to the right path. I can generate a valid
> image for my system and I even had a "hello world" driver as an external
> package. For the driver I want to integrate, I need to fix a few calls
> which, I believe, should be done with a patch. As I understand, there are at
> least 2 ways to place the patch. The first one is to have a global patch
> directory (BR2_GLOBAL_PATCH_DIR) or to place the patch in the package
> directory. I did both.
> My problem is that the patch seems to be ignored and is not applied.
>
> For the info, I tried:
> make mypackage-dirclean
> make mypackage-patch V=1
>
> The second command doesn't output anything about the patch, only the "rsync"
> command.
>
> Could the patch not be applied because the source files are local?
Correct: when you use <pkg>_SITE_METHOD = local or
<pkg>_OVERRIDE_SRCDIR in local.mk, we simply rsync the source code, and
the patching step is skipped.
The assumption is that if the source tree is local... you'd rather
have the changes you need made on it directly, rather than having
patches in Buildroot.
This sadly doesn't seem to be mentioned in the Buildroot manual, and it
should be fixed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-07 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 12:26 [Buildroot] Patch not being applied to out of tree package ngu
2017-07-07 13:52 ` Thomas Petazzoni [this message]
2017-07-07 14:12 ` Nicolas G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707155257.78b51950@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox