[Buildroot] Patch not being applied to out of tree package

[Buildroot] Patch not being applied to out of tree package

[ngu]

Hello all,

My goal is to integrate a driver to buildroot.
From what I understand, the best way to do so is to create a package, this
is what I did. The package is out of tree which is not a problem a I
correctly set the BR2_EXTERNAL to the right path. I can generate a valid
image for my system and I even had a "hello world" driver as an external
package. For the driver I want to integrate, I need to fix a few calls
which, I believe, should be done with a patch. As I understand, there are at
least 2 ways to place the patch. The first one is to have a global patch
directory (BR2_GLOBAL_PATCH_DIR) or to place the patch in the package
directory. I did both.
My problem is that the patch seems to be ignored and is not applied.

For the info, I tried:
make mypackage-dirclean
make mypackage-patch V=1

The second command doesn't output anything about the patch, only the "rsync"
command.
I tested the same patch with a package in the tree (i.e. nano) and the patch
was found and applied (of course, it failed).

Could the patch not be applied because the source files are local? Is there
any reason why a patch could be ignored and not mentionned in the log? How
can I get additional information about what is going on during the patching
process?





--
View this message in context: http://buildroot-busybox.2317881.n4.nabble.com/Patch-not-being-applied-to-out-of-tree-package-tp170337.html
Sent from the Buildroot (busybox) mailing list archive at Nabble.com.

[Buildroot] Patch not being applied to out of tree package

[Thomas Petazzoni]

Hello,

On Fri, 7 Jul 2017 05:26:23 -0700 (PDT), ngu wrote:

> My goal is to integrate a driver to buildroot.
> From what I understand, the best way to do so is to create a package, this
> is what I did. The package is out of tree which is not a problem a I
> correctly set the BR2_EXTERNAL to the right path. I can generate a valid
> image for my system and I even had a "hello world" driver as an external
> package. For the driver I want to integrate, I need to fix a few calls
> which, I believe, should be done with a patch. As I understand, there are at
> least 2 ways to place the patch. The first one is to have a global patch
> directory (BR2_GLOBAL_PATCH_DIR) or to place the patch in the package
> directory. I did both.
> My problem is that the patch seems to be ignored and is not applied.
> 
> For the info, I tried:
> make mypackage-dirclean
> make mypackage-patch V=1
> 
> The second command doesn't output anything about the patch, only the "rsync"
> command.
>
> Could the patch not be applied because the source files are local?

Correct: when you use <pkg>_SITE_METHOD = local or
<pkg>_OVERRIDE_SRCDIR in local.mk, we simply rsync the source code, and
the patching step is skipped.

The assumption is that if the source tree is local... you'd rather
have the changes you need made on it directly, rather than having
patches in Buildroot.

This sadly doesn't seem to be mentioned in the Buildroot manual, and it
should be fixed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] Patch not being applied to out of tree package

[Nicolas G.]

Hello Thomas,

Thank you for your reply! This makes sense.

Nicolas



--
View this message in context: http://buildroot-busybox.2317881.n4.nabble.com/Patch-not-being-applied-to-out-of-tree-package-tp170337p170341.html
Sent from the Buildroot (busybox) mailing list archive at Nabble.com.