From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/7] support/testing: move BRTest initialisation to __init__
Date: Mon, 10 Jul 2017 01:21:20 +0200 [thread overview]
Message-ID: <20170709232123.30120-5-arnout@mind.be> (raw)
In-Reply-To: <20170709232123.30120-1-arnout@mind.be>
BRTest's setUp() method contains a few assignments that initialize its
member variables. Since we will want to use these in test case
overrides, move them to the __init__ function.
Also allow the config member to be overridden, rather than always
taking the class member.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
support/testing/infra/basetest.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/support/testing/infra/basetest.py b/support/testing/infra/basetest.py
index d75458a02c..2a5c9ec939 100644
--- a/support/testing/infra/basetest.py
+++ b/support/testing/infra/basetest.py
@@ -36,15 +36,18 @@ class BRTest(unittest.TestCase):
keepbuilds = False
jlevel = None
+ def __init__(self, names):
+ super(BRTest, self).__init__(names)
+ self.testname = self.__class__.__name__
+ self.builddir = os.path.join(self.__class__.outputdir, self.testname)
+ self.emulator = None
+
def show_msg(self, msg):
print "{} {:40s} {}".format(datetime.datetime.now().strftime("%H:%M:%S"),
self.testname, msg)
def setUp(self):
- self.testname = self.__class__.__name__
- self.builddir = os.path.join(self.__class__.outputdir, self.testname)
- self.emulator = None
self.show_msg("Starting")
- config = self.__class__.config
+ config = self.config
if self.jlevel:
config += "BR2_JLEVEL={}\n".format(self.jlevel)
self.b = Builder(config, self.builddir, self.logtofile)
--
2.13.2
next prev parent reply other threads:[~2017-07-09 23:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 23:21 [Buildroot] [PATCH 0/7] More HOST_DIR/usr fixes Arnout Vandecappelle
2017-07-09 23:21 ` [Buildroot] [PATCH 1/7] Makefile: properly create $(HOST_DIR)/usr compatibility symlink Arnout Vandecappelle
2017-07-10 15:59 ` Thomas Petazzoni
2017-07-09 23:21 ` [Buildroot] [PATCH 2/7] toolchain-wrapper: remove remaining references to HOST_DIR/usr Arnout Vandecappelle
2017-07-10 15:59 ` Thomas Petazzoni
2017-07-09 23:21 ` [Buildroot] [PATCH 3/7] support/testing: strip /usr/ part from HOST_DIR Arnout Vandecappelle
2017-07-10 15:59 ` Thomas Petazzoni
2017-07-09 23:21 ` Arnout Vandecappelle [this message]
2017-07-10 15:59 ` [Buildroot] [PATCH 4/7] support/testing: move BRTest initialisation to __init__ Thomas Petazzoni
2017-07-09 23:21 ` [Buildroot] [PATCH 5/7] support/testing: add test of BR2_CCACHE with an external toolchain Arnout Vandecappelle
2017-07-10 16:01 ` Thomas Petazzoni
2017-07-10 20:10 ` Arnout Vandecappelle
2017-07-09 23:21 ` [Buildroot] [PATCH 6/7] Makefile: add check that $(HOST_DIR)/usr is not a directory Arnout Vandecappelle
2017-07-10 16:02 ` Thomas Petazzoni
2017-07-10 16:12 ` Yann E. MORIN
2017-07-10 19:51 ` Arnout Vandecappelle
2017-07-10 20:09 ` Arnout Vandecappelle
2017-07-10 21:27 ` Thomas Petazzoni
2017-07-10 21:36 ` Arnout Vandecappelle
2017-07-10 21:43 ` Yann E. MORIN
2017-07-09 23:21 ` [Buildroot] [PATCH 7/7] toolchain-external: default BR2_TOOLCHAIN_EXTERNAL_PATH to empty Arnout Vandecappelle
2017-07-10 16:03 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170709232123.30120-5-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox