* [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option
@ 2017-07-17 12:22 Vicente Olivert Riera
2017-07-17 12:22 ` [Buildroot] [PATCH 2/2] arch/mips: improve help text of FP32 mode option Vicente Olivert Riera
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vicente Olivert Riera @ 2017-07-17 12:22 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
arch/Config.in.mips | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/Config.in.mips b/arch/Config.in.mips
index 7dd69659d..f2b352b0b 100644
--- a/arch/Config.in.mips
+++ b/arch/Config.in.mips
@@ -169,7 +169,9 @@ choice
depends on BR2_mips_32r5 || BR2_mips_64r5
default BR2_MIPS_ENABLE_NAN_2008
help
- NaN encoding to be used
+ MIPS supports two different NaN encodings, legacy and 2008.
+ Information about MIPS NaN encodings can be found here:
+ https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
config BR2_MIPS_ENABLE_NAN_LEGACY
bool "legacy"
--
2.13.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 2/2] arch/mips: improve help text of FP32 mode option
2017-07-17 12:22 [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Vicente Olivert Riera
@ 2017-07-17 12:22 ` Vicente Olivert Riera
2017-07-17 12:56 ` [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Thomas Petazzoni
2017-07-19 19:48 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Vicente Olivert Riera @ 2017-07-17 12:22 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
arch/Config.in.mips | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/Config.in.mips b/arch/Config.in.mips
index f2b352b0b..de71110e0 100644
--- a/arch/Config.in.mips
+++ b/arch/Config.in.mips
@@ -139,7 +139,10 @@ choice
depends on !BR2_ARCH_IS_64 && !BR2_MIPS_SOFT_FLOAT
default BR2_MIPS_FP32_MODE_XX
help
- FP mode to be used
+ MIPS32 supports different FP modes (32,xx,64). Information about FP
+ modes can be found here:
+ https://sourceware.org/binutils/docs/as/MIPS-Options.html
+ https://dmz-portal.imgtec.com/wiki/MIPS_O32_ABI_-_FR0_and_FR1_Interlinking#5._Generating_modeless_code
config BR2_MIPS_FP32_MODE_32
bool "32"
--
2.13.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option
2017-07-17 12:22 [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Vicente Olivert Riera
2017-07-17 12:22 ` [Buildroot] [PATCH 2/2] arch/mips: improve help text of FP32 mode option Vicente Olivert Riera
@ 2017-07-17 12:56 ` Thomas Petazzoni
2017-07-17 16:57 ` Vicente Olivert Riera
2017-07-19 19:48 ` Thomas Petazzoni
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2017-07-17 12:56 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:
> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
> index 7dd69659d..f2b352b0b 100644
> --- a/arch/Config.in.mips
> +++ b/arch/Config.in.mips
> @@ -169,7 +169,9 @@ choice
> depends on BR2_mips_32r5 || BR2_mips_64r5
> default BR2_MIPS_ENABLE_NAN_2008
> help
> - NaN encoding to be used
> + MIPS supports two different NaN encodings, legacy and 2008.
> + Information about MIPS NaN encodings can be found here:
> + https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
Is it useful (and correct?) to say that the Linux kernel, built for
MIPS32r5, by default expect the 2008 NaN encoding?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option
2017-07-17 12:56 ` [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Thomas Petazzoni
@ 2017-07-17 16:57 ` Vicente Olivert Riera
2017-07-18 7:53 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Olivert Riera @ 2017-07-17 16:57 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On 17/07/17 13:56, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:
>
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index 7dd69659d..f2b352b0b 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -169,7 +169,9 @@ choice
>> depends on BR2_mips_32r5 || BR2_mips_64r5
>> default BR2_MIPS_ENABLE_NAN_2008
>> help
>> - NaN encoding to be used
>> + MIPS supports two different NaN encodings, legacy and 2008.
>> + Information about MIPS NaN encodings can be found here:
>> + https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
>
> Is it useful (and correct?) to say that the Linux kernel, built for
> MIPS32r5, by default expect the 2008 NaN encoding?
It is correct, but since nan2008 is the default I think is not worth
mentioning it. If you change the default value is because you know what
you are doing, right?
Vincent
>
> Thomas
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option
2017-07-17 16:57 ` Vicente Olivert Riera
@ 2017-07-18 7:53 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-07-18 7:53 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Jul 2017 17:57:22 +0100, Vicente Olivert Riera wrote:
> > Is it useful (and correct?) to say that the Linux kernel, built for
> > MIPS32r5, by default expect the 2008 NaN encoding?
>
> It is correct, but since nan2008 is the default I think is not worth
> mentioning it. If you change the default value is because you know what
> you are doing, right?
OK, makes sense. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option
2017-07-17 12:22 [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Vicente Olivert Riera
2017-07-17 12:22 ` [Buildroot] [PATCH 2/2] arch/mips: improve help text of FP32 mode option Vicente Olivert Riera
2017-07-17 12:56 ` [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Thomas Petazzoni
@ 2017-07-19 19:48 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-07-19 19:48 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> arch/Config.in.mips | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Both applied, thanks!
Have you had the chance to look at the -mnan issue with old gcc
versions ? This is currently making the autobuilders quite noisy, which
isn't nice.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-19 19:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-17 12:22 [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Vicente Olivert Riera
2017-07-17 12:22 ` [Buildroot] [PATCH 2/2] arch/mips: improve help text of FP32 mode option Vicente Olivert Riera
2017-07-17 12:56 ` [Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option Thomas Petazzoni
2017-07-17 16:57 ` Vicente Olivert Riera
2017-07-18 7:53 ` Thomas Petazzoni
2017-07-19 19:48 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox