From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] libglib2: disable compiler warnings
Date: Wed, 19 Jul 2017 15:23:48 +0200 [thread overview]
Message-ID: <20170719152348.66d289c3@windsurf> (raw)
In-Reply-To: <87d18wbmc1.fsf@dell.be.48ers.dk>
Hello,
On Wed, 19 Jul 2017 15:14:22 +0200, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
>
> > commit: https://git.buildroot.net/buildroot/commit/?id=f2800ac57cde2cd71df295d33441faae1b30dd3e
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> > By default, libglib enables some fairly aggressive warnings, treated
> > as errors. In particular, the -Wformat=2 warning triggers a warning
> > due to the return value of the ngettext() macro from uClibc libintl
> > stub not being understood as being potentially a format string.
>
> > So, before we enable the stub libintl in uClibc, we disable such
> > warnings. A bug will be reported to upstream uClibc to get the actual
> > bug fixed, but disabling compiler warnings treated as errors is anyway
> > a good thing in the context of Buildroot.
>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Committed to 2017.02.x and 2017.05.x, thanks.
Doesn't do much harm, but it wasn't causing any visible issue in
2017.02/2017.05 I believe. It's really enabling the uClibc-ng intl stub
that triggered that warning.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-19 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 17:09 [Buildroot] [git commit] libglib2: disable compiler warnings Thomas Petazzoni
2017-07-19 13:14 ` Peter Korsgaard
2017-07-19 13:23 ` Thomas Petazzoni [this message]
2017-07-19 18:59 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719152348.66d289c3@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox