[Buildroot] [git commit] libglib2: disable compiler warnings

[Buildroot] [git commit] libglib2: disable compiler warnings

[Thomas Petazzoni]

commit: https://git.buildroot.net/buildroot/commit/?id=f2800ac57cde2cd71df295d33441faae1b30dd3e
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

By default, libglib enables some fairly aggressive warnings, treated
as errors. In particular, the -Wformat=2 warning triggers a warning
due to the return value of the ngettext() macro from uClibc libintl
stub not being understood as being potentially a format string.

So, before we enable the stub libintl in uClibc, we disable such
warnings. A bug will be reported to upstream uClibc to get the actual
bug fixed, but disabling compiler warnings treated as errors is anyway
a good thing in the context of Buildroot.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/libglib2/libglib2.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
index d6b18dd..577dcec 100644
--- a/package/libglib2/libglib2.mk
+++ b/package/libglib2/libglib2.mk
@@ -113,7 +113,8 @@ HOST_LIBGLIB2_DEPENDENCIES = \
 	host-zlib
 
 LIBGLIB2_CONF_OPTS = \
-	--with-pcre=system
+	--with-pcre=system \
+	--disable-compile-warnings
 
 ifneq ($(BR2_ENABLE_LOCALE),y)
 LIBGLIB2_DEPENDENCIES += libiconv

[Buildroot] [git commit] libglib2: disable compiler warnings

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=f2800ac57cde2cd71df295d33441faae1b30dd3e
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > By default, libglib enables some fairly aggressive warnings, treated
 > as errors. In particular, the -Wformat=2 warning triggers a warning
 > due to the return value of the ngettext() macro from uClibc libintl
 > stub not being understood as being potentially a format string.

 > So, before we enable the stub libintl in uClibc, we disable such
 > warnings. A bug will be reported to upstream uClibc to get the actual
 > bug fixed, but disabling compiler warnings treated as errors is anyway
 > a good thing in the context of Buildroot.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed to 2017.02.x and 2017.05.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [git commit] libglib2: disable compiler warnings

[Thomas Petazzoni]

Hello,

On Wed, 19 Jul 2017 15:14:22 +0200, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:  
> 
>  > commit: https://git.buildroot.net/buildroot/commit/?id=f2800ac57cde2cd71df295d33441faae1b30dd3e
>  > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master  
> 
>  > By default, libglib enables some fairly aggressive warnings, treated
>  > as errors. In particular, the -Wformat=2 warning triggers a warning
>  > due to the return value of the ngettext() macro from uClibc libintl
>  > stub not being understood as being potentially a format string.  
> 
>  > So, before we enable the stub libintl in uClibc, we disable such
>  > warnings. A bug will be reported to upstream uClibc to get the actual
>  > bug fixed, but disabling compiler warnings treated as errors is anyway
>  > a good thing in the context of Buildroot.  
> 
>  > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>  > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>  > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>  
> 
> Committed to 2017.02.x and 2017.05.x, thanks.

Doesn't do much harm, but it wasn't causing any visible issue in
2017.02/2017.05 I believe. It's really enabling the uClibc-ng intl stub
that triggered that warning.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [git commit] libglib2: disable compiler warnings

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> Committed to 2017.02.x and 2017.05.x, thanks.

 > Doesn't do much harm, but it wasn't causing any visible issue in
 > 2017.02/2017.05 I believe. It's really enabling the uClibc-ng intl stub
 > that triggered that warning.

Correct, I added it as it seemed "safe", and would fix any other
warnings that would trigger Werror failures.

-- 
Bye, Peter Korsgaard