From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4 v3] package/kvm-unit-tests: introduce _ARCH_SUPPORTS
Date: Sat, 22 Jul 2017 23:28:26 +0200 [thread overview]
Message-ID: <20170722232826.68061aec@windsurf> (raw)
In-Reply-To: <996d1d52c27da1a7725ed425ac895c3a7b5b7301.1499592591.git.yann.morin.1998@free.fr>
Hello,
On Sun, 9 Jul 2017 11:29:59 +0200, Yann E. MORIN wrote:
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 if BR2_i386
> + depends on BR2_HOST_GCC_AT_LEAST_4_5 if BR2_x86_64
Did you actually test this? "make menuconfig" complains:
thomas at windsurf:~/projets/buildroot (master)$ make menuconfig
package/kvm-unit-tests/Config.in:16: syntax error
package/kvm-unit-tests/Config.in:15: invalid option
package/kvm-unit-tests/Config.in:17: syntax error
package/kvm-unit-tests/Config.in:16: invalid option
Makefile:876: recipe for target 'menuconfig' failed
So I've replaced them with the more usual:
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 || !BR2_i386
+ depends on BR2_HOST_GCC_AT_LEAST_4_5 || !BR2_x86_64
I've also re-add the Config.in comment about the host gcc >= 4.5
dependency.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-07-22 21:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 9:29 [Buildroot] [PATCH 0/4 v3] arch/arm: introduce big.LITTLE configurations Yann E. MORIN
2017-07-09 9:29 ` [Buildroot] [PATCH 1/4 v3] arch/arm: fix -mcpu default values for AArch64 Yann E. MORIN
2017-07-10 16:04 ` Thomas Petazzoni
2017-07-10 16:18 ` Tomov, Pavel
2017-07-10 16:22 ` Yann E. MORIN
2017-07-19 13:59 ` Peter Korsgaard
2017-07-09 9:29 ` [Buildroot] [PATCH 2/4 v3] package/kvm-unit-tests: introduce _ARCH_SUPPORTS Yann E. MORIN
2017-07-10 16:09 ` Thomas Petazzoni
2017-07-10 16:20 ` Yann E. MORIN
2017-07-10 19:56 ` Arnout Vandecappelle
2017-07-10 20:10 ` Yann E. MORIN
2017-07-10 20:12 ` Arnout Vandecappelle
2017-07-10 20:19 ` Yann E. MORIN
2017-07-10 21:47 ` Thomas Petazzoni
2017-07-10 21:57 ` Yann E. MORIN
2017-07-11 21:14 ` Arnout Vandecappelle
2017-07-22 21:28 ` Thomas Petazzoni [this message]
2017-07-22 21:49 ` Yann E. MORIN
2017-07-09 9:30 ` [Buildroot] [PATCH 3/4 v3] arch/arm: add big.LITTLE cpu variants Yann E. MORIN
2017-07-22 21:29 ` Thomas Petazzoni
2017-07-09 9:30 ` [Buildroot] [PATCH 4/4 v3] package/kvm-unit-test: available for big.LITTLE arm cores too Yann E. MORIN
2017-07-22 21:29 ` Thomas Petazzoni
2017-07-22 21:50 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170722232826.68061aec@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox