* [Buildroot] [git commit] support/testing: add test of BR2_CCACHE with an external toolchain
@ 2017-07-24 16:35 Thomas Petazzoni
2017-07-24 17:54 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2017-07-24 16:35 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=6355ec2768c486de318b76835af73fdcb894b311
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
We reuse TestExternalToolchainBuildrootuClibc and add ccache to its
configuration.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
.gitlab-ci.yml | 1 +
support/testing/tests/toolchain/test_external.py | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 57710ab..42707ad 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -233,6 +233,7 @@ tests.package.test_python.TestPython2: *runtime_test
tests.package.test_python.TestPython3: *runtime_test
tests.toolchain.test_external.TestExternalToolchainBuildrootMusl: *runtime_test
tests.toolchain.test_external.TestExternalToolchainBuildrootuClibc: *runtime_test
+tests.toolchain.test_external.TestExternalToolchainCCache: *runtime_test
tests.toolchain.test_external.TestExternalToolchainCtngMusl: *runtime_test
tests.toolchain.test_external.TestExternalToolchainLinaroArm: *runtime_test
tests.toolchain.test_external.TestExternalToolchainSourceryArmv4: *runtime_test
diff --git a/support/testing/tests/toolchain/test_external.py b/support/testing/tests/toolchain/test_external.py
index afb4bb0..394fa17 100644
--- a/support/testing/tests/toolchain/test_external.py
+++ b/support/testing/tests/toolchain/test_external.py
@@ -229,3 +229,14 @@ BR2_TOOLCHAIN_EXTERNAL_CXX=y
kernel="builtin",
options=["-initrd", img])
self.emulator.login()
+
+class TestExternalToolchainCCache(TestExternalToolchainBuildrootuClibc):
+ extraconfig = \
+"""
+BR2_CCACHE=y
+BR2_CCACHE_DIR="{builddir}/ccache-dir"
+"""
+
+ def __init__(self, names):
+ super(TestExternalToolchainBuildrootuClibc, self).__init__(names)
+ self.config += self.extraconfig.format(builddir=self.builddir)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [git commit] support/testing: add test of BR2_CCACHE with an external toolchain
2017-07-24 16:35 [Buildroot] [git commit] support/testing: add test of BR2_CCACHE with an external toolchain Thomas Petazzoni
@ 2017-07-24 17:54 ` Yann E. MORIN
2017-07-24 22:54 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2017-07-24 17:54 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2017-07-24 18:35 +0200, Thomas Petazzoni spake thusly:
> commit: https://git.buildroot.net/buildroot/commit/?id=6355ec2768c486de318b76835af73fdcb894b311
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> We reuse TestExternalToolchainBuildrootuClibc and add ccache to its
> configuration.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> .gitlab-ci.yml | 1 +
> support/testing/tests/toolchain/test_external.py | 11 +++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 57710ab..42707ad 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -233,6 +233,7 @@ tests.package.test_python.TestPython2: *runtime_test
> tests.package.test_python.TestPython3: *runtime_test
> tests.toolchain.test_external.TestExternalToolchainBuildrootMusl: *runtime_test
> tests.toolchain.test_external.TestExternalToolchainBuildrootuClibc: *runtime_test
> +tests.toolchain.test_external.TestExternalToolchainCCache: *runtime_test
> tests.toolchain.test_external.TestExternalToolchainCtngMusl: *runtime_test
> tests.toolchain.test_external.TestExternalToolchainLinaroArm: *runtime_test
> tests.toolchain.test_external.TestExternalToolchainSourceryArmv4: *runtime_test
You don't need to list all tests in there, if you want to execute all
of them.i
Instead, you can just list 'tests' and all sub-tests will be run by
nose2. This way we need not update this file with every new test that we
add. And in fact I think we should not even need to list it, and make
the runtime-test entry just run everything...
I think it is even possible to mark some tests with 'test campaign tag'
so that they are only executed under some conditions that we define
ourselves (like, 'nightly', 'weekly', but also like 'arm', 'mips' or
whatever 'tag' we're interested in). If you think it might be usefull,
I can research that further...
Regards,
Yann E. MORIN.
> diff --git a/support/testing/tests/toolchain/test_external.py b/support/testing/tests/toolchain/test_external.py
> index afb4bb0..394fa17 100644
> --- a/support/testing/tests/toolchain/test_external.py
> +++ b/support/testing/tests/toolchain/test_external.py
> @@ -229,3 +229,14 @@ BR2_TOOLCHAIN_EXTERNAL_CXX=y
> kernel="builtin",
> options=["-initrd", img])
> self.emulator.login()
> +
> +class TestExternalToolchainCCache(TestExternalToolchainBuildrootuClibc):
> + extraconfig = \
> +"""
> +BR2_CCACHE=y
> +BR2_CCACHE_DIR="{builddir}/ccache-dir"
> +"""
> +
> + def __init__(self, names):
> + super(TestExternalToolchainBuildrootuClibc, self).__init__(names)
> + self.config += self.extraconfig.format(builddir=self.builddir)
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [git commit] support/testing: add test of BR2_CCACHE with an external toolchain
2017-07-24 17:54 ` Yann E. MORIN
@ 2017-07-24 22:54 ` Arnout Vandecappelle
2017-07-25 7:03 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2017-07-24 22:54 UTC (permalink / raw)
To: buildroot
On 24-07-17 19:54, Yann E. MORIN wrote:
[snip]
> You don't need to list all tests in there, if you want to execute all
> of them.i
I think Thomas first implemented it that way. But then gitlab-CI just reports a
single pass/fail for the entire test suite, without details about what failed.
AFAIK gitlab-CI reporting doesn't have xUnit integration that could be used to
report detailed results from a single run.
Regards,
Arnout
> Instead, you can just list 'tests' and all sub-tests will be run by
> nose2. This way we need not update this file with every new test that we
> add. And in fact I think we should not even need to list it, and make
> the runtime-test entry just run everything...
>
> I think it is even possible to mark some tests with 'test campaign tag'
> so that they are only executed under some conditions that we define
> ourselves (like, 'nightly', 'weekly', but also like 'arm', 'mips' or
> whatever 'tag' we're interested in). If you think it might be usefull,
> I can research that further...
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [git commit] support/testing: add test of BR2_CCACHE with an external toolchain
2017-07-24 22:54 ` Arnout Vandecappelle
@ 2017-07-25 7:03 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2017-07-25 7:03 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 25 Jul 2017 00:54:30 +0200, Arnout Vandecappelle wrote:
> > You don't need to list all tests in there, if you want to execute all
> > of them.i
>
> I think Thomas first implemented it that way. But then gitlab-CI just reports a
> single pass/fail for the entire test suite, without details about what failed.
> AFAIK gitlab-CI reporting doesn't have xUnit integration that could be used to
> report detailed results from a single run.
I didn't implement it in a single pass, simply because I knew I wanted
Gitlab CI to show the breakdown per test, and not a global pass/fail
status. But Arnout's explanation remains true: if we simply do
a "./support/testing/run-tests -a", then we would have a single entry
in the Gitlab CI report that says if the entire test suite has passed
or fail. I believe the current situation, where each test is known as a
separate "thing" by Gitlab CI is better.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-25 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-24 16:35 [Buildroot] [git commit] support/testing: add test of BR2_CCACHE with an external toolchain Thomas Petazzoni
2017-07-24 17:54 ` Yann E. MORIN
2017-07-24 22:54 ` Arnout Vandecappelle
2017-07-25 7:03 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox