[Buildroot] [PATCH 1/1] package/python-service-identity: the attrs distribution is required

[Buildroot] [PATCH 1/1] package/python-service-identity: the attrs distribution is required

[Charles Hardin]

Apparently the service identify code requires the python attrs
to be availabe:

Traceback (most recent call last):
  File "/opt/exablox/bin/configsrv", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3138, in <module>
    @_call_aside
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3124, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3151, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 661, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 962, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 849, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'attrs' distribution was not found and is required by service-identity

Signed-off-by: Charles Hardin <ckhardin@exablox.com>
---
 package/python-service-identity/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-service-identity/Config.in b/package/python-service-identity/Config.in
index 304b38acde..73593b0d61 100644
--- a/package/python-service-identity/Config.in
+++ b/package/python-service-identity/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PYTHON_SERVICE_IDENTITY
 	bool "python-service-identity"
 	depends on BR2_INSTALL_LIBSTDCPP # python-pyopenssl, python-pyasn
+	select BR2_PACKAGE_PYTHON_ATTRS # runtime
 	select BR2_PACKAGE_PYTHON_CHARACTERISTIC # runtime
 	select BR2_PACKAGE_PYTHON_PYASN # runtime
 	select BR2_PACKAGE_PYTHON_PYASN_MODULES # runtime
-- 
2.11.0 (Apple Git-81)

[Buildroot] [PATCH 1/1] package/python-service-identity: the attrs distribution is required

[Yegor Yefremov]

On Wed, Jul 26, 2017 at 8:59 PM, Charles Hardin <ckhardin@exablox.com> wrote:
> Apparently the service identify code requires the python attrs
> to be availabe:
>
> Traceback (most recent call last):
>   File "/opt/exablox/bin/configsrv", line 5, in <module>
>     from pkg_resources import load_entry_point
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3138, in <module>
>     @_call_aside
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3124, in _call_aside
>     f(*args, **kwargs)
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3151, in _initialize_master_working_set
>     working_set = WorkingSet._build_master()
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 661, in _build_master
>     ws.require(__requires__)
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 962, in require
>     needed = self.resolve(parse_requirements(requirements))
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 849, in resolve
>     raise DistributionNotFound(req, requirers)
> pkg_resources.DistributionNotFound: The 'attrs' distribution was not found and is required by service-identity
>
> Signed-off-by: Charles Hardin <ckhardin@exablox.com>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

> ---
>  package/python-service-identity/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/python-service-identity/Config.in b/package/python-service-identity/Config.in
> index 304b38acde..73593b0d61 100644
> --- a/package/python-service-identity/Config.in
> +++ b/package/python-service-identity/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PYTHON_SERVICE_IDENTITY
>         bool "python-service-identity"
>         depends on BR2_INSTALL_LIBSTDCPP # python-pyopenssl, python-pyasn
> +       select BR2_PACKAGE_PYTHON_ATTRS # runtime
>         select BR2_PACKAGE_PYTHON_CHARACTERISTIC # runtime
>         select BR2_PACKAGE_PYTHON_PYASN # runtime
>         select BR2_PACKAGE_PYTHON_PYASN_MODULES # runtime
> --
> 2.11.0 (Apple Git-81)
>

[Buildroot] [PATCH 1/1] package/python-service-identity: the attrs distribution is required

[Thomas Petazzoni]

Hello,

On Wed, 26 Jul 2017 11:59:56 -0700, Charles Hardin wrote:
> Apparently the service identify code requires the python attrs
> to be availabe:
> 
> Traceback (most recent call last):
>   File "/opt/exablox/bin/configsrv", line 5, in <module>
>     from pkg_resources import load_entry_point
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3138, in <module>
>     @_call_aside
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3124, in _call_aside
>     f(*args, **kwargs)
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3151, in _initialize_master_working_set
>     working_set = WorkingSet._build_master()
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 661, in _build_master
>     ws.require(__requires__)
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 962, in require
>     needed = self.resolve(parse_requirements(requirements))
>   File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 849, in resolve
>     raise DistributionNotFound(req, requirers)
> pkg_resources.DistributionNotFound: The 'attrs' distribution was not found and is required by service-identity
> 
> Signed-off-by: Charles Hardin <ckhardin@exablox.com>
> ---
>  package/python-service-identity/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] package/python-service-identity: the attrs distribution is required

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Wed, 26 Jul 2017 11:59:56 -0700, Charles Hardin wrote:
 >> Apparently the service identify code requires the python attrs
 >> to be availabe:
 >> 
 >> Traceback (most recent call last):
 >> File "/opt/exablox/bin/configsrv", line 5, in <module>
 >> from pkg_resources import load_entry_point
 >> File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3138, in <module>
 >> @_call_aside
 >> File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3124, in _call_aside
 >> f(*args, **kwargs)
 >> File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3151, in _initialize_master_working_set
 >> working_set = WorkingSet._build_master()
 >> File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 661, in _build_master
 >> ws.require(__requires__)
 >> File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 962, in require
 >> needed = self.resolve(parse_requirements(requirements))
 >> File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 849, in resolve
 >> raise DistributionNotFound(req, requirers)
 >> pkg_resources.DistributionNotFound: The 'attrs' distribution was not found and is required by service-identity
 >> 
 >> Signed-off-by: Charles Hardin <ckhardin@exablox.com>
 >> ---
 >> package/python-service-identity/Config.in | 1 +
 >> 1 file changed, 1 insertion(+)

 > Applied to master, thanks.

While looking at this commit for backporting to 2017.02.x, it seems like
the select of BR2_PACKAGE_PYTHON_CHARACTERISTIC should be dropped after
the bump to 16.0.0, as it is isn't listed in INSTALL_REQUIRES. PKG-INFO
states:

Changes:
        - Port from ``characteristic`` to its spiritual successor `attrs <https://attrs.readthedocs.org/>`_.

Care to verify and send a patch to drop the select if OK?

In the mean time I've applied this patch to the 2017.02.x series,
thanks.

-- 
Bye, Peter Korsgaard