[Buildroot] [PATCH 1/1] package/qt5/qt5base: examples depend on OpenGL

[Peter Seiderer <ps.report@gmx.net>]

Hello Bernd,

On Mon, 7 Aug 2017 18:41:49 +0200, Peter Seiderer <ps.report@gmx.net> wrote:

> Hello Bernd,
> 
> On Mon,  7 Aug 2017 09:03:44 +0200, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> 
> > Fixes
> > http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/
> > 
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > ---
> >  package/qt5/qt5base/Config.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
> > index f5de27228..f0138a10f 100644
> > --- a/package/qt5/qt5base/Config.in
> > +++ b/package/qt5/qt5base/Config.in
> > @@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
> >  
> >  config BR2_PACKAGE_QT5BASE_EXAMPLES
> >  	bool "Compile and install examples (with code)"
> > +	depends on BR2_PACKAGE_QT5_GL_AVAILABLE
> 
> Did not (yet) look at the details, but disabling all examples (mind that all sub
> modules use BR2_PACKAGE_QT5BASE_EXAMPLES) because of one failing one seems a bit
> over-reacted....better solution would be to disable only the failing one, see
> e.g. package/qt5/qt5declarative/0002-examples-qquickviewcomparison-and-quickwidget-needs-.patch
> 

Alternative patch submitted, see [1]...

Regards,
Peter

[1] https://patchwork.ozlabs.org/patch/798899

> Regards,
> Peter
> 
> >  	select BR2_PACKAGE_QT5BASE_NETWORK
> >  	select BR2_PACKAGE_QT5BASE_XML
> >  	help
> >  	  If unsure, say N.
> >  
> > +comment "Examples need an OpenGL-capable backend"
> > +	depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
> > +
> >  config BR2_PACKAGE_QT5BASE_NETWORK
> >  	def_bool y
> >  
>