* [Buildroot] [PATCH 1/1] package/qt5/qt5base: examples depend on OpenGL
@ 2017-08-07 7:03 Bernd Kuhls
2017-08-07 16:41 ` Peter Seiderer
0 siblings, 1 reply; 3+ messages in thread
From: Bernd Kuhls @ 2017-08-07 7:03 UTC (permalink / raw)
To: buildroot
Fixes
http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/qt5/qt5base/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
index f5de27228..f0138a10f 100644
--- a/package/qt5/qt5base/Config.in
+++ b/package/qt5/qt5base/Config.in
@@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
config BR2_PACKAGE_QT5BASE_EXAMPLES
bool "Compile and install examples (with code)"
+ depends on BR2_PACKAGE_QT5_GL_AVAILABLE
select BR2_PACKAGE_QT5BASE_NETWORK
select BR2_PACKAGE_QT5BASE_XML
help
If unsure, say N.
+comment "Examples need an OpenGL-capable backend"
+ depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
+
config BR2_PACKAGE_QT5BASE_NETWORK
def_bool y
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/qt5/qt5base: examples depend on OpenGL
2017-08-07 7:03 [Buildroot] [PATCH 1/1] package/qt5/qt5base: examples depend on OpenGL Bernd Kuhls
@ 2017-08-07 16:41 ` Peter Seiderer
2017-08-07 21:18 ` Peter Seiderer
0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2017-08-07 16:41 UTC (permalink / raw)
To: buildroot
Hello Bernd,
On Mon, 7 Aug 2017 09:03:44 +0200, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Fixes
> http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/qt5/qt5base/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
> index f5de27228..f0138a10f 100644
> --- a/package/qt5/qt5base/Config.in
> +++ b/package/qt5/qt5base/Config.in
> @@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
>
> config BR2_PACKAGE_QT5BASE_EXAMPLES
> bool "Compile and install examples (with code)"
> + depends on BR2_PACKAGE_QT5_GL_AVAILABLE
Did not (yet) look at the details, but disabling all examples (mind that all sub
modules use BR2_PACKAGE_QT5BASE_EXAMPLES) because of one failing one seems a bit
over-reacted....better solution would be to disable only the failing one, see
e.g. package/qt5/qt5declarative/0002-examples-qquickviewcomparison-and-quickwidget-needs-.patch
Regards,
Peter
> select BR2_PACKAGE_QT5BASE_NETWORK
> select BR2_PACKAGE_QT5BASE_XML
> help
> If unsure, say N.
>
> +comment "Examples need an OpenGL-capable backend"
> + depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
> +
> config BR2_PACKAGE_QT5BASE_NETWORK
> def_bool y
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/qt5/qt5base: examples depend on OpenGL
2017-08-07 16:41 ` Peter Seiderer
@ 2017-08-07 21:18 ` Peter Seiderer
0 siblings, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2017-08-07 21:18 UTC (permalink / raw)
To: buildroot
Hello Bernd,
On Mon, 7 Aug 2017 18:41:49 +0200, Peter Seiderer <ps.report@gmx.net> wrote:
> Hello Bernd,
>
> On Mon, 7 Aug 2017 09:03:44 +0200, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> > Fixes
> > http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/
> >
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > ---
> > package/qt5/qt5base/Config.in | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
> > index f5de27228..f0138a10f 100644
> > --- a/package/qt5/qt5base/Config.in
> > +++ b/package/qt5/qt5base/Config.in
> > @@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
> >
> > config BR2_PACKAGE_QT5BASE_EXAMPLES
> > bool "Compile and install examples (with code)"
> > + depends on BR2_PACKAGE_QT5_GL_AVAILABLE
>
> Did not (yet) look at the details, but disabling all examples (mind that all sub
> modules use BR2_PACKAGE_QT5BASE_EXAMPLES) because of one failing one seems a bit
> over-reacted....better solution would be to disable only the failing one, see
> e.g. package/qt5/qt5declarative/0002-examples-qquickviewcomparison-and-quickwidget-needs-.patch
>
Alternative patch submitted, see [1]...
Regards,
Peter
[1] https://patchwork.ozlabs.org/patch/798899
> Regards,
> Peter
>
> > select BR2_PACKAGE_QT5BASE_NETWORK
> > select BR2_PACKAGE_QT5BASE_XML
> > help
> > If unsure, say N.
> >
> > +comment "Examples need an OpenGL-capable backend"
> > + depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
> > +
> > config BR2_PACKAGE_QT5BASE_NETWORK
> > def_bool y
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-07 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-07 7:03 [Buildroot] [PATCH 1/1] package/qt5/qt5base: examples depend on OpenGL Bernd Kuhls
2017-08-07 16:41 ` Peter Seiderer
2017-08-07 21:18 ` Peter Seiderer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox