* [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend @ 2017-08-09 0:09 Joshua Henderson 2017-08-09 7:38 ` Peter Seiderer 0 siblings, 1 reply; 5+ messages in thread From: Joshua Henderson @ 2017-08-09 0:09 UTC (permalink / raw) To: buildroot libgtk3 can conditionally be build with or without the X11 backend unlike libgtk2. If libgtk3 is enabled and the X11 backend is not enabled for BR2_PACKAGE_QT5_VERSION_LATEST, a build error [1] is introduced. This change disables gtk support in this case. [1] http://autobuild.buildroot.net/results/6f3c2fcb0a44cd13ef4c73822d4d08f923291099 Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> Cc: Julien Corjon <corjon.j@ecagroup.com> Cc: Brent Sink <brents_3@hotmail.com> Cc: Naoki Matsumoto <n-matsumoto@melcoinc.co.jp> --- package/qt5/qt5base/qt5base.mk | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk index bbbdd41..1b4bd7b 100644 --- a/package/qt5/qt5base/qt5base.mk +++ b/package/qt5/qt5base/qt5base.mk @@ -190,6 +190,16 @@ else QT5BASE_CONFIGURE_OPTS += -no-libinput endif +ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST)$(BR2_PACKAGE_LIBGTK3),yy) +# only enable gtk support if libgtk3 X11 backend is enabled +ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y) +QT5BASE_CONFIGURE_OPTS += -gtk +QT5BASE_DEPENDENCIES += libgtk3 +else +QT5BASE_CONFIGURE_OPTS += -no-gtk +endif +endif + # Build the list of libraries to be installed on the target QT5BASE_INSTALL_LIBS_y += Qt5Core QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_XCB) += Qt5XcbQpa -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend 2017-08-09 0:09 [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend Joshua Henderson @ 2017-08-09 7:38 ` Peter Seiderer 2017-08-09 21:53 ` Arnout Vandecappelle 0 siblings, 1 reply; 5+ messages in thread From: Peter Seiderer @ 2017-08-09 7:38 UTC (permalink / raw) To: buildroot Hello Joshua, > Gesendet: Mittwoch, 09. August 2017 um 02:09 Uhr > Von: "Joshua Henderson" <joshua.henderson@microchip.com> > An: buildroot at buildroot.org > Cc: "Peter Seiderer" <ps.report@gmx.net>, "Julien Corjon" <corjon.j@ecagroup.com>, "Brent Sink" <brents_3@hotmail.com>, "Naoki Matsumoto" <n-matsumoto@melcoinc.co.jp> > Betreff: [PATCH] package/qt5base: libgtk3 support depends on X11 backend > > libgtk3 can conditionally be build with or without the X11 backend unlike > libgtk2. If libgtk3 is enabled and the X11 backend is not enabled for > BR2_PACKAGE_QT5_VERSION_LATEST, a build error [1] is introduced. This change > disables gtk support in this case. NAK - or only as a workaround, the real issue is a missing QT_EGL_NO_X11/MESA_EGL_NO_X11_HEADERS define, see e.g. [2] for further discussion... Regards, Peter [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196075.html > > [1] http://autobuild.buildroot.net/results/6f3c2fcb0a44cd13ef4c73822d4d08f923291099 > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> > Cc: Julien Corjon <corjon.j@ecagroup.com> > Cc: Brent Sink <brents_3@hotmail.com> > Cc: Naoki Matsumoto <n-matsumoto@melcoinc.co.jp> > --- > package/qt5/qt5base/qt5base.mk | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk > index bbbdd41..1b4bd7b 100644 > --- a/package/qt5/qt5base/qt5base.mk > +++ b/package/qt5/qt5base/qt5base.mk > @@ -190,6 +190,16 @@ else > QT5BASE_CONFIGURE_OPTS += -no-libinput > endif > > +ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST)$(BR2_PACKAGE_LIBGTK3),yy) > +# only enable gtk support if libgtk3 X11 backend is enabled > +ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y) > +QT5BASE_CONFIGURE_OPTS += -gtk > +QT5BASE_DEPENDENCIES += libgtk3 > +else > +QT5BASE_CONFIGURE_OPTS += -no-gtk > +endif > +endif > + > # Build the list of libraries to be installed on the target > QT5BASE_INSTALL_LIBS_y += Qt5Core > QT5BASE_INSTALL_LIBS_$(BR2_PACKAGE_QT5BASE_XCB) += Qt5XcbQpa > -- > 2.7.4 > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend 2017-08-09 7:38 ` Peter Seiderer @ 2017-08-09 21:53 ` Arnout Vandecappelle 2017-08-10 21:17 ` Peter Seiderer 0 siblings, 1 reply; 5+ messages in thread From: Arnout Vandecappelle @ 2017-08-09 21:53 UTC (permalink / raw) To: buildroot Hi Peter, On 09-08-17 09:38, Peter Seiderer wrote: > Hello Joshua, > >> Gesendet: Mittwoch, 09. August 2017 um 02:09 Uhr >> Von: "Joshua Henderson" <joshua.henderson@microchip.com> >> An: buildroot at buildroot.org >> Cc: "Peter Seiderer" <ps.report@gmx.net>, "Julien Corjon" <corjon.j@ecagroup.com>, "Brent Sink" <brents_3@hotmail.com>, "Naoki Matsumoto" <n-matsumoto@melcoinc.co.jp> >> Betreff: [PATCH] package/qt5base: libgtk3 support depends on X11 backend >> >> libgtk3 can conditionally be build with or without the X11 backend unlike >> libgtk2. If libgtk3 is enabled and the X11 backend is not enabled for >> BR2_PACKAGE_QT5_VERSION_LATEST, a build error [1] is introduced. This change >> disables gtk support in this case. > NAK - or only as a workaround, the real issue is a missing QT_EGL_NO_X11/MESA_EGL_NO_X11_HEADERS > define, see e.g. [2] for further discussion... Do you expect a proper resolution to arrive before 2017.08, or should I apply Joshua's patch (with modified commit message) to master after all? Regards, Arnout > > Regards, > Peter > > [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196075.html > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend 2017-08-09 21:53 ` Arnout Vandecappelle @ 2017-08-10 21:17 ` Peter Seiderer 2017-08-11 12:07 ` Arnout Vandecappelle 0 siblings, 1 reply; 5+ messages in thread From: Peter Seiderer @ 2017-08-10 21:17 UTC (permalink / raw) To: buildroot Hello Arnout, On Wed, 9 Aug 2017 23:53:52 +0200, Arnout Vandecappelle <arnout@mind.be> wrote: > Hi Peter, > > On 09-08-17 09:38, Peter Seiderer wrote: > > Hello Joshua, > > > >> Gesendet: Mittwoch, 09. August 2017 um 02:09 Uhr > >> Von: "Joshua Henderson" <joshua.henderson@microchip.com> > >> An: buildroot at buildroot.org > >> Cc: "Peter Seiderer" <ps.report@gmx.net>, "Julien Corjon" <corjon.j@ecagroup.com>, "Brent Sink" <brents_3@hotmail.com>, "Naoki Matsumoto" <n-matsumoto@melcoinc.co.jp> > >> Betreff: [PATCH] package/qt5base: libgtk3 support depends on X11 backend > >> > >> libgtk3 can conditionally be build with or without the X11 backend unlike > >> libgtk2. If libgtk3 is enabled and the X11 backend is not enabled for > >> BR2_PACKAGE_QT5_VERSION_LATEST, a build error [1] is introduced. This change > >> disables gtk support in this case. > > NAK - or only as a workaround, the real issue is a missing QT_EGL_NO_X11/MESA_EGL_NO_X11_HEADERS > > define, see e.g. [2] for further discussion... > > Do you expect a proper resolution to arrive before 2017.08, or should I apply > Joshua's patch (with modified commit message) to master after all? Would prefer to try patch [3] or add MESA_EGL_NO_X11_HEADERS define via arch.conf (as done e.g. for libatomic by Yann's patch [4])...but will not find enough time the next two weeks to try... Regards, Peter [3] https://codereview.qt-project.org/#/c/198906/ [4] https://git.buildroot.net/buildroot/commit/?id=7d286be4f96cfb731e184c3e8cfea27a031bde3c > > Regards, > Arnout > > > > > Regards, > > Peter > > > > [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196075.html > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend 2017-08-10 21:17 ` Peter Seiderer @ 2017-08-11 12:07 ` Arnout Vandecappelle 0 siblings, 0 replies; 5+ messages in thread From: Arnout Vandecappelle @ 2017-08-11 12:07 UTC (permalink / raw) To: buildroot On 10-08-17 23:17, Peter Seiderer wrote: > Hello Arnout, > > On Wed, 9 Aug 2017 23:53:52 +0200, Arnout Vandecappelle <arnout@mind.be> wrote: > >> Hi Peter, >> >> On 09-08-17 09:38, Peter Seiderer wrote: >>> Hello Joshua, >>> >>>> Gesendet: Mittwoch, 09. August 2017 um 02:09 Uhr >>>> Von: "Joshua Henderson" <joshua.henderson@microchip.com> >>>> An: buildroot at buildroot.org >>>> Cc: "Peter Seiderer" <ps.report@gmx.net>, "Julien Corjon" <corjon.j@ecagroup.com>, "Brent Sink" <brents_3@hotmail.com>, "Naoki Matsumoto" <n-matsumoto@melcoinc.co.jp> >>>> Betreff: [PATCH] package/qt5base: libgtk3 support depends on X11 backend >>>> >>>> libgtk3 can conditionally be build with or without the X11 backend unlike >>>> libgtk2. If libgtk3 is enabled and the X11 backend is not enabled for >>>> BR2_PACKAGE_QT5_VERSION_LATEST, a build error [1] is introduced. This change >>>> disables gtk support in this case. >>> NAK - or only as a workaround, the real issue is a missing QT_EGL_NO_X11/MESA_EGL_NO_X11_HEADERS >>> define, see e.g. [2] for further discussion... >> >> Do you expect a proper resolution to arrive before 2017.08, or should I apply >> Joshua's patch (with modified commit message) to master after all? > > Would prefer to try patch [3] or add MESA_EGL_NO_X11_HEADERS define via > arch.conf (as done e.g. for libatomic by Yann's patch [4])...but will > not find enough time the next two weeks to try... Also your reference [3] got negative review, and doing it through arch.conf sounds like a hack. So I've applied to master, with a few changes: - extend commit message - improve comment - also pass -no-gtk if libgtk3 is not selected Regards, Arnout > > Regards, > Peter > > [3] https://codereview.qt-project.org/#/c/198906/ > [4] https://git.buildroot.net/buildroot/commit/?id=7d286be4f96cfb731e184c3e8cfea27a031bde3c > >> >> Regards, >> Arnout >> >>> >>> Regards, >>> Peter >>> >>> [2] http://lists.busybox.net/pipermail/buildroot/2017-July/196075.html >>> >> > > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-11 12:07 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-08-09 0:09 [Buildroot] [PATCH] package/qt5base: libgtk3 support depends on X11 backend Joshua Henderson 2017-08-09 7:38 ` Peter Seiderer 2017-08-09 21:53 ` Arnout Vandecappelle 2017-08-10 21:17 ` Peter Seiderer 2017-08-11 12:07 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox